Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove the ligature 0x #346

Closed
yvvt0379 opened this issue Oct 25, 2020 · 7 comments
Closed

Please remove the ligature 0x #346

yvvt0379 opened this issue Oct 25, 2020 · 7 comments

Comments

@yvvt0379
Copy link

yvvt0379 commented Oct 25, 2020

Let's return to the origin: Why do we need ligatures? Take ≤ and ≥ for example. As we all know, these two symbols represents 'less-equal' and 'greater-equal'. However, they cannot be directly typed with a keyboard, so we came up with an alternative solution -- use a combination of symbols -- <= and >=. However, when we see these two symbol combinations, our brains needs some time to associate them with 'less-equal' and 'greater-equal', because when we were very little, it's ≤ and ≥ , not <= and >= ,that our teachers taught us to represent these two meanings. So the original purpose of ligatures is to reduce the workload of our brains and make the code more readable.
However, when it comes to 0x, situations are different. Personally, I don't think it a good idea to turn 0x into 0×, because when we see 0×ff, we tend to think it as '0 multiplied by ff', instead of a hexadecimal number that equals the decimal number 255, which runs counter to the original purpose of ligatures. Instead, I think removing the ligature is better.
In addition, I disagree with the idea of turning 0x into hex or so on, because it changes 0x into a completely different symbol (see 0xff, hexff and 0₁₆ff).
In summary, I think that removing the ligature for 0x is a good idea.

@philippnurullin
Copy link
Member

Hi @CodeCrazy-ywt All the discussion happen to be in this issue #98
In the next update this ligature will be removed.

@yvvt0379
Copy link
Author

OK. Great thanks!

@philippnurullin
Copy link
Member

Forgot to mention this in the Changelog. The ligature was removed in 2.210

@manide
Copy link

manide commented Nov 11, 2020

Hmm, using version 2.210, but still get a ligature for 0x when it's followed by a digit (not for other characters though).
0xLigature

philippnurullin added a commit that referenced this issue Nov 12, 2020
- Tuned Vietnamese diacritics more, removed errors in Ẫ
- Removed 0x0 ligature #346
- Added ⟵ ⟷ ⟶ #255
- Corrected vertical placement on BoxDrawing elements
- Updated Changelog and changed format from .txt to .md
@philippnurullin
Copy link
Member

philippnurullin commented Nov 12, 2020

Sorry, didn't remove all the code in the 2.210. You can grab the files from latest push (2.211). It's fixed there.
https://github.com/JetBrains/JetBrainsMono/tree/master/fonts

@yvvt0379
Copy link
Author

So I wonder when will v2.211 be released.

@Calinou
Copy link

Calinou commented Dec 29, 2020

@CodeCrazy-ywt It's released now: https://github.com/JetBrains/JetBrainsMono/releases/tag/v2.221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants