Fix crash when we resize ComposePanel after re-adding it to the hierarchy #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rchy Fixes JetBrains/compose-multiplatform#4479 The crash was because the closed container didn't unsubscribe from the parent size changes. ## Testing A new test
igordmn
force-pushed
the
igor.demin/fix-composepanel-resize-crash
branch
from
6c9d541
to
bc29e81
Compare
MatkovIvan
reviewed
Mar 14, 2024
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/ComposeContainer.desktop.kt
Show resolved
Hide resolved
MatkovIvan
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JetBrains/compose-multiplatform#4479
The crash was because the closed container didn't unsubscribe from the parent size changes.
Testing
A new test