Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when we resize ComposePanel after re-adding it to the hierarchy #4479

Closed
igordmn opened this issue Mar 14, 2024 · 0 comments · Fixed by JetBrains/compose-multiplatform-core#1195
Closed

Crash when we resize ComposePanel after re-adding it to the hierarchy #4479

igordmn opened this issue Mar 14, 2024 · 0 comments · Fixed by JetBrains/compose-multiplatform-core#1195
Assignees
@igordmn
Labels
bug Something isn't working p:high High priority swing interop Swing interop issue

Comments

@igordmn
Copy link
Collaborator

igordmn commented Mar 14, 2024

Compose 1.6.10-dev1509

  1. Clone to the Jewel repro: https://github.com/JetBrains/jewel
  2. Run the ide sample configuration
  3. Open an empty project
  4. Wait for sync
  5. Open the "Jewel Demo" tool window
  6. Select the compose sample tab within the tool window
  7. Toggle the tool window to close it
  8. Reopen the "Jewel Demo" tool window
  9. Resize Intellij
  10. Observe error
ComposeScene is closed
@igordmn igordmn added bug Something isn't working p:high High priority swing interop Swing interop issue labels Mar 14, 2024
@igordmn igordmn self-assigned this Mar 14, 2024
igordmn added a commit to JetBrains/compose-multiplatform-core that referenced this issue Mar 14, 2024
@igordmn
Fix crash when we resize ComposePanel after re-adding it to the hiera…
baa6af4 
…rchy

Fixes JetBrains/compose-multiplatform#4479

The crash was because the closed container didn't unsubscribe from the parent size changes.

## Testing
A new test
igordmn added a commit to JetBrains/compose-multiplatform-core that referenced this issue Mar 14, 2024
@igordmn
Fix crash when we resize ComposePanel after re-adding it to the hiera…
6c9d541 
…rchy

Fixes JetBrains/compose-multiplatform#4479

The crash was because the closed container didn't unsubscribe from the parent size changes.

## Testing
A new test
@igordmn igordmn mentioned this issue Mar 14, 2024
Merged
igordmn added a commit to JetBrains/compose-multiplatform-core that referenced this issue Mar 14, 2024
@igordmn
Fix crash when we resize ComposePanel after re-adding it to the hiera…
bc29e81 
…rchy

Fixes JetBrains/compose-multiplatform#4479

The crash was because the closed container didn't unsubscribe from the parent size changes.

## Testing
A new test
igordmn added a commit to JetBrains/compose-multiplatform-core that referenced this issue Mar 14, 2024
@igordmn
Fix crash when we resize ComposePanel after re-adding it to the hiera…
08b27dc 
…rchy (#1195)

Fixes JetBrains/compose-multiplatform#4479

The crash was because the closed container didn't unsubscribe from the
parent size changes.

## Testing
A new test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igordmn igordmn

Labels
bug Something isn't working p:high High priority swing interop Swing interop issue
Projects
None yet
Milestone
No milestone
1 participant
@igordmn