Fix updating root constraints #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but I'd prefer other people to look at it as well. Can't completely assess possible side effects of this solution as opposed to manual invalidation call. |
igordmn
approved these changes
Jun 7, 2024
elijah-semyonov
added a commit
that referenced
this pull request
Jun 10, 2024
Explicitly manage lifetime of metal drawables by hiding them from Kotlin runtime. Fixes a memory spike when quickly resizing metal layer as in a scenario reported in [the issue](JetBrains/compose-multiplatform#4850) Otherwise associated drawable pools are retained until next GC, which can happen after inadequate amount of drawables with new sizes are allocated ### Before: <img width="414" alt="Screenshot 2024-06-06 at 13 33 46" src="https://github.com/JetBrains/compose-multiplatform-core/assets/4167681/81d74dfe-91c0-4362-ad71-93416dbe172f"> ### After: <img width="574" alt="Screenshot 2024-06-07 at 10 04 18" src="https://github.com/JetBrains/compose-multiplatform-core/assets/4167681/6574b297-1e81-48db-9aee-d31c2425267c"> ## Testing Resize the popup with `ComposeUIViewController` to different detents inside Demo `IosBugs/PopupStretching` Requires either patch: ``` Index: compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.uikit.kt IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== diff --git a/compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.uikit.kt b/compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.uikit.kt --- a/compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.uikit.kt (revision 39d436a) +++ b/compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.uikit.kt (date 1717747754590) @@ -558,6 +558,7 @@ asDpRect().toRect() } } + onComposeSceneInvalidate() scene.size = IntSize( width = boundsInPx.width.roundToInt(), height = boundsInPx.height.roundToInt() ``` Or #1387 ## Release Notes ### iOS - Fixes - Fixed a memory spike when continuously resizing the `ComposeUIViewController` (such as when used in modal sheet presentation context with different detents)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
owner.sizedoesn't really observed during composition setting scene size might not trigger invalidationsupdateRootConstraintsinstead of marking size as stateFixes stretching reported in JetBrains/compose-multiplatform#4850
Testing
Run
MultiLayerComposeSceneTestRelease Notes
Fixes - iOS