Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt focus interop code to Compose 1.7 changes #1398

Merged
merged 5 commits into from
Jun 10, 2024

Discussions

bbf01e8
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Adapt focus interop code to Compose 1.7 changes #1398

Discussions
bbf01e8
Select commit
Loading
Failed to load commit list.
GitHub Actions / iOS CMP Utils tests results failed Jun 10, 2024 in 0s

Xcode test results

Testing project CMPUIKitUtils with scheme CMPUIKitUtilsTests

Summary

TotalSuccess PassedFailure FailedSkipped SkippedExpected Failure Expected Failure⏱️ Time
981001.08s

Test Summary

CMPUIKitUtilsTests

  • Device: iPhone 15, 17.2 (21C62)
  • SDK: Simulator - iOS 17.0, 17.0
TestTotalSuccessFailureSkippedExpected Failure
test-class CMPViewControllerTests98100

Failure Failures

CMPUIKitUtilsTests/CMPViewControllerTests/testFullscreenPresentationOnTop()

File/Users/runner/work/compose-multiplatform-core/compose-multiplatform-core/compose/ui/ui-uikit/src/uikitMain/objc/CMPUIKitUtils/CMPUIKitUtils/CMPViewController.m:105
Issue TypeUncaught Exception
MessageCMPViewController shouldn't be reused after completely removed from hierarchy, because it's logically marked as Destroyed. You must create a new CMPViewController and use it instead. (CMPViewControllerMisuse)

Code Coverage

Coverage Covered Executable
CMPUIKitUtilsTestApp.app 66.01 % 202 306
  CMPAccessibilityElement.m 0.00 % 0 69
  CMPOSLoggerInterval.m 100.00 % 14 14
  CMPViewController.m 89.11 % 90 101
  CMPUIKitUtilsTestApp.swift 100.00 % 64 64
  CMPOSLogger.m 100.00 % 34 34
  CMPAccessibilityContainer.m 0.00 % 0 24
libCMPUIKitUtils.a 57.02 % 138 242
  CMPOSLoggerInterval.m 100.00 % 14 14
  CMPOSLogger.m 100.00 % 34 34
  CMPAccessibilityElement.m 0.00 % 0 69
  CMPAccessibilityContainer.m 0.00 % 0 24
  CMPViewController.m 89.11 % 90 101
Total 62.04 % 340 548

Details

Test Details

CMPUIKitUtilsTestsback

CMPViewControllerTests back

SuccessFailureSkippedExpected Failure⏱️
8 (89%)1 (11%)0 (0%)0 (0%)1.08s
Successtest-method testChildController()
Failuretest-method testFullscreenPresentationOnTop()back
Successtest-method testFullScreenPresentationSandwich()
Successtest-method testNavigationControllerPresentAndPush2()
Successtest-method testNavigationControllerPresentAndPush()
Successtest-method testNotAttached()
Successtest-method testPresentAndDismiss()
Successtest-method testRootViewController()
Successtest-method testTabBarControllerPresentAndPush()

Annotations

Check failure on line 105 in CMPUIKitUtils/CMPViewController.m

See this annotation in the file changed.

@github-actions github-actions / iOS CMP Utils tests results

Uncaught Exception

CMPViewController shouldn't be reused after completely removed from hierarchy, because it's logically marked as Destroyed. You must create a new CMPViewController and use it instead. (CMPViewControllerMisuse)