-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Magnifier for iOS 17+ #969
Conversation
Hello! Thank you for the request. |
I'd wait for #980. It contains stable magnifier definition that is slightly different from current |
Hello, @alexzhirkevich! Just in case, here is some useful information:
If that is cumbersome, we also gladly accept changes only in platform sourceSets. |
Let's have it in uikitMain only for now then? Anyway the amount of people using this modifier for purposes other than text selection is quite low I guess. Having default magnifier for text fields and selection container will close 99% of this modifier usage. Modifier itself can be internal for now, just to implement the default text selection magnifier that I lack a lot. |
Yes, I think making uikit only implementation of magnifier is a good solution here 👍 |
@mazunin-v-jb RPReplay_Final1705527572.MP4Double tap with hidden keyboard causes menu flashing: RPReplay_Final1705527489.MP4Double tap menu with open keyboard is incorrect. If you then drag this text a little bit, correct menu shows: RPReplay_Final1705527500.MP4 |
Merged with 1.6 beta and moved to uikit-only here: #1000 |
@alexzhirkevich, thank you! I'll take a look Upd. I reproduced the first issue, but couldn't reproduce the second one. Could you please create an issue here with the flashing context menu and tag me in it? |
There is no extra info i can provide actually except that i run mpp app on 12 mini /17.2.1. May be related to the #964. Or because of ClearFocusBox is used there |
@mazunin-v-jb Yep, it does not happen on Example1 screen. Seems like ClearFocusBox issue |
Proposed Changes
Testing
Test: try magnifier in all types of text fields
Issues Fixed
Fixes: JetBrains/compose-multiplatform#3692