Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commonize Modifier.magnifier #3692

Open
igordmn opened this issue Sep 15, 2023 · 1 comment
Open

Commonize Modifier.magnifier #3692

igordmn opened this issue Sep 15, 2023 · 1 comment
Labels
commonization enhancement New feature or request

Comments

@igordmn
Copy link
Collaborator

igordmn commented Sep 15, 2023

See https://github.com/androidx/androidx/blob/41cb7d5c422180edd89efde4076f9dc724d3a313/compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/Magnifier.kt#L94

It's API is applicable to commonMain, but it is in androidMain

Magnifier is usual useful during text selection

@igordmn igordmn added enhancement New feature or request commonization labels Sep 15, 2023
mazunin-v-jb pushed a commit to JetBrains/compose-multiplatform-core that referenced this issue Apr 5, 2024
## Proposed Changes

- Text field and selection container magnifier for iOS 17+

<img
src="https://github.com/JetBrains/compose-multiplatform-core/assets/63979218/f7fd9432-066f-4cc3-ad96-5029bfe75848"
height = 300>

## Testing

Test: try magnifier in all types of text fields

## Issues Fixed

Partly: JetBrains/compose-multiplatform#3692
@okushnikov
Copy link

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commonization enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants