-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Platform layers clip popup shadows #4460
Platform layers clip popup shadows #4460
Comments
It's a known, documented limitation at the moment. See docs:
You can use old behaviour with Since there was no issue about it on GitHub, let's keep it to track this |
Is there any benefits of using platform layers in full-compose app? |
May be this should've been mentioned in the Breaking Changes section as it is set by default and kinda breaks popups that've been working before |
A new way is generally a more correct approach - Compose was designed there in a way to bind each layout node root to a separate platform view. In the case of a full-screen compose app - set of our old hacks should work fine. However, it might affect things like more correct a11y binding etc. We're considering
The limitation itself shouldn't be in "Breaking Changes" - we'll fix it in future releases (already have some draft), but probably the point about |
## Proposed Changes - Use skia's BBHFactory to track real drawing bounds - requires JetBrains/skiko#889 (skiko `0.7.98`) - Adding additional click filtering to handle clicks on "shadow" area as click outside ## Testing Test: Try to use new platform layers with shadows <img width="695" alt="image" src="https://github.com/JetBrains/compose-multiplatform-core/assets/1836384/80dce85f-814d-4d51-ab5e-6535ed976d48"> ## Issues Fixed Fixes: JetBrains/compose-multiplatform#4460
Affected platforms
Versions
To Reproduce
The text was updated successfully, but these errors were encountered: