-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose BBHFactory
to record bounds in Picture
#889
Conversation
Is it doing this always now? I don't have any specific knowledge, but it could slow drawing... See JetBrains/compose-multiplatform-core#1090 and https://issues.skia.org/issues/324465764 |
no, it just exposes a parameter. |
I'd recommend checking whether it affects performance when there are many objects drawn, before using it for drawing arbitrary user-provided objects in Compose. If it doesn't affect performance, we should use it instead of my hack with the large picture size. |
Had another thought - is it possible to avoid managing and passing the BBH factory in/out of the JVM? We only need it there to know when to delete it. Maybe an API like a |
It does, so we decided not to use it always, only when it is really needed
It can be even simpler, but we decided to keep original skia API |
## Proposed Changes - Use skia's BBHFactory to track real drawing bounds - requires JetBrains/skiko#889 (skiko `0.7.98`) - Adding additional click filtering to handle clicks on "shadow" area as click outside ## Testing Test: Try to use new platform layers with shadows <img width="695" alt="image" src="https://github.com/JetBrains/compose-multiplatform-core/assets/1836384/80dce85f-814d-4d51-ab5e-6535ed976d48"> ## Issues Fixed Fixes: JetBrains/compose-multiplatform#4460
No description provided.