Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archiving domains #1279

Closed
kronosapiens opened this issue Jul 23, 2024 · 0 comments · Fixed by #1280
Closed

Archiving domains #1279

kronosapiens opened this issue Jul 23, 2024 · 0 comments · Fixed by #1280

Comments

@kronosapiens
Copy link
Member

kronosapiens commented Jul 23, 2024

This is functionality that we've had, and taken away, and are re-implementing now:

Add deprecateDomain: #983
Add support for local skills: #986
Remove global skills: #1173

Also this comment: 305266f#r740362477

This history has led us into a strange state where each change was path-dependent on the change before. We initially implemented domain deprecation before we had local skills; we tried to update it to use local skills once we had them, which ultimately failed due to unforeseen interactions between colonies, and then went ahead and removed global skills, the feature which required the functionality which made local skill deprecation impossible.

Ultimately, we have sort of come full-circle where we can now implement local skill deprecation as initially envisioned, as there is no longer a need to store any deprecation information on the network itself. However, deploying that change presents some small challenges, namely any currently-deprecated skills will become undeprecated, as we will move from network-stored deprecation to colony-stored deprecation, which necessarily has not been set yet.

Speaking to @arrenv, it is unlikely this change will effect many users, if any, as very few users are still active on Gnosis chain, and it is likely that only a small handful of users ever used this functionality in the first place (although this is hard to verify, as the events are recorded on the individual colonies).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant