-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroduce domain deprecation #1280
Conversation
f9dc857
to
d1bc2ec
Compare
e01599d
to
030da01
Compare
What on earth has happened to |
e58aee8
to
5f60345
Compare
5f60345
to
5ca6132
Compare
1a55020
to
22a012b
Compare
cc726a3
to
9376b82
Compare
e4703a8
to
a539a2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good. Just need to work out how to convince myself further that it won't brick everything with the return data change when calling getDomain
.
a539a2a
to
f33bc54
Compare
I spent this afternoon getting extremely comfortable with Remix and EVM Opcodes to convince myself further that returning too much data in a call is okay, and I believe it is. I might end up adding to the relevant OneTxPayment test though. I also don't believe bricking the mining cycle is a risk after all, as the only |
6ecae63
to
c6d9a09
Compare
That's now merged, but not yet deployed... so closer, at least! |
Needs #1299 merged, and then versions bumped accordingly. |
e3368e6
to
24c6e80
Compare
24c6e80
to
a073fc3
Compare
90d004c
to
122680f
Compare
Closes #1279
This PR restores the ability to deprecate domains and local skills. It also moves skills deprecation entirely to the colony level and away from the network, completing the process begun in #1173.
There are two migration considerations, both of which I believe are relatively minor:
localSkills
boolean mapping is deprecated and replaced by aLocalSkill
struct mapping. For already-extant local skills, validity and deprecation behaviors are preserved.The point to emphasize is that these migration issues affect functionality that has been deprecated for some time. As such, the actual effects are likely to be very minor.
TODO: