Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versioning check script #1299

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

area
Copy link
Member

@area area commented Oct 1, 2024

Prior to the release of IMWSS2, the last-but-one-release (HMWSS) used npm. After IMWSS2, the last-but-one-release (IMWSS) uses pnpm. So the version check script needs to be updated.

What confused me was that it was silently failing, when I added set -e recently to avoid exactly this scenario.

It turns out, if you carefully inspect the documentation:

              -e    ...  The shell does not exit if the command that fails is part of the command list
                      immediately following a while or until keyword, part of the test following  the  if
                      or  elif reserved words, part of any command executed in a && or || list except the
                      command following the final && or ||, any command in a pipeline but the last, or if
                      the command's return value is being inverted with !. 

So I have removed the use of && to avoid a situation like this cropping up in the future.

@area area merged commit 47dd2e9 into develop Oct 2, 2024
2 checks passed
@area area deleted the maint/update-version-check-script branch October 2, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants