Add deprecateDomain #983
Merged
Add deprecateDomain #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronosapiens
force-pushed
the
feat/deprecate-domains
branch
from
ab509f4 to
d973cb3
Compare
area
reviewed
Sep 10, 2021
kronosapiens
force-pushed
the
feat/deprecate-domains
branch
from
187f566 to
1af9627
Compare
area
reviewed
Oct 16, 2021
kronosapiens
force-pushed
the
feat/deprecate-domains
branch
from
1af9627 to
a374825
Compare
kronosapiens
force-pushed
the
feat/deprecate-domains
branch
from
7c36c9e to
d0ee8b6
Compare
kronosapiens
force-pushed
the
feat/deprecate-domains
branch
from
d0ee8b6 to
6977d09
Compare
area
force-pushed
the
feat/deprecate-domains
branch
from
02841c2 to
55de7ca
Compare
area
approved these changes
Oct 19, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #979
Allow for one-off domain deprecation (i.e. deprecating a domain does not deprecate the parents or children).
A deprecated domain cannot:
I also took advantage of the opportunity to remove some lingering
msg.sendercalls which we no longer need.