Skip to content

fix(decompile): safe array access when building abi #611

fix(decompile): safe array access when building abi

fix(decompile): safe array access when building abi #611

Triggered via pull request September 2, 2024 19:47
Status Success
Total duration 5m 48s
Artifacts

tests.yml

on: pull_request
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

9 warnings
clippy
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, giraffate/clippy-action@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
clippy: crates/cache/src/lib.rs#L299
[clippy] reported by reviewdog 🐶 <pre><code>warning: first doc comment paragraph is too long --> crates/cache/src/lib.rs:299:1 | 299 | / /// Takes in an &str and an async function that returns a Result<T, E> where T is ser/de 300 | | /// and E is an error type. \ 301 | | /// If the key exists in the cache, it will return the value, otherwise it will call the function 302 | | /// and store the result in the cache, returning the value. | |_ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph = note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default </code></pre> Raw Output: crates/cache/src/lib.rs:299:1:w: <pre><code>warning: first doc comment paragraph is too long --> crates/cache/src/lib.rs:299:1 | 299 | / /// Takes in an &str and an async function that returns a Result<T, E> where T is ser/de 300 | | /// and E is an error type. \ 301 | | /// If the key exists in the cache, it will return the value, otherwise it will call the function 302 | | /// and store the result in the cache, returning the value. | |_ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph = note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default </code></pre> __END__
clippy: crates/vm/src/core/stack.rs#L20
[clippy] reported by reviewdog 🐶 <pre><code>warning: first doc comment paragraph is too long --> crates/vm/src/core/stack.rs:20:1 | 20 | / /// The [`StackFrame`] struct represents a single frame on the stack. 21 | | /// It holds a [`U256`] value and the [`WrappedOpcode`] that pushed it onto the stack. \ 22 | | /// \ 23 | | /// By doing this, we can keep track of the source of each value on the stack in a recursive manner. | |_ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph = note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default help: add an empty line | 20 ~ /// The [`StackFrame`] struct represents a single frame on the stack. 21 + /// | </code></pre> Raw Output: crates/vm/src/core/stack.rs:20:1:w: <pre><code>warning: first doc comment paragraph is too long --> crates/vm/src/core/stack.rs:20:1 | 20 | / /// The [`StackFrame`] struct represents a single frame on the stack. 21 | | /// It holds a [`U256`] value and the [`WrappedOpcode`] that pushed it onto the stack. \ 22 | | /// \ 23 | | /// By doing this, we can keep track of the source of each value on the stack in a recursive manner. | |_ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph = note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default help: add an empty line | 20 ~ /// The [`StackFrame`] struct represents a single frame on the stack. 21 + /// | </code></pre> __END__
clippy: crates/vm/src/core/vm.rs#L78
[clippy] reported by reviewdog 🐶 <pre><code>warning: first doc comment paragraph is too long --> crates/vm/src/core/vm.rs:78:1 | 78 | / /// [`Instruction`] is a single EVM instruction. It is returned by the [`VM::step`] function, and 79 | | /// contains necessary tracing information, such as the opcode executed, it's inputs and outputs, as 80 | | /// well as their parent operations. | |_ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph </code></pre> Raw Output: crates/vm/src/core/vm.rs:78:1:w: <pre><code>warning: first doc comment paragraph is too long --> crates/vm/src/core/vm.rs:78:1 | 78 | / /// [`Instruction`] is a single EVM instruction. It is returned by the [`VM::step`] function, and 79 | | /// contains necessary tracing information, such as the opcode executed, it's inputs and outputs, as 80 | | /// well as their parent operations. | |_ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph </code></pre> __END__
clippy: crates/vm/src/core/vm.rs#L751
[clippy] reported by reviewdog 🐶 <pre><code>warning: use of a fallible conversion when an infallible one could be used --> crates/vm/src/core/vm.rs:751:33 | 751 | self.stack.push(U256::try_from(result)?, operation); | ^^^^^^^^^^^^^^ help: use: `From::from` | = note: converting `FixedBytes<32>` to `Uint<256, 4>` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default </code></pre> Raw Output: crates/vm/src/core/vm.rs:751:33:w: <pre><code>warning: use of a fallible conversion when an infallible one could be used --> crates/vm/src/core/vm.rs:751:33 | 751 | self.stack.push(U256::try_from(result)?, operation); | ^^^^^^^^^^^^^^ help: use: `From::from` | = note: converting `FixedBytes<32>` to `Uint<256, 4>` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default </code></pre> __END__
clippy: crates/cli/src/args.rs#L45
[clippy] reported by reviewdog 🐶 <pre><code>warning: name `CFG` contains a capitalized acronym --> crates/cli/src/args.rs:45:5 | 45 | CFG(CFGArgs), | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cfg` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms = note: `#[warn(clippy::upper_case_acronyms)]` on by default </code></pre> Raw Output: crates/cli/src/args.rs:45:5:w: <pre><code>warning: name `CFG` contains a capitalized acronym --> crates/cli/src/args.rs:45:5 | 45 | CFG(CFGArgs), | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cfg` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms = note: `#[warn(clippy::upper_case_acronyms)]` on by default </code></pre> __END__
check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
test macos-latest
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
test ubuntu-latest
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/