Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Raise test coverage to "green" percentage #204

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 6, 2024 · 0 comments · Fixed by #205
Closed
3 tasks done

🛠 Tooling: Raise test coverage to "green" percentage #204

JoshuaKGoldberg opened this issue Jan 6, 2024 · 0 comments · Fixed by #205
Assignees
@JoshuaKGoldberg
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Right now, codecov indicates test coverage for this repo is 75%. That shows up with an orange background in the README.md badge, on its scale from red to orange to yellow to green. Not an ideal look for the repository.

Additional Info

Having badges angrily proclaim low test coverage numbers is part of why I like having them in the README.md 😄. It's good encouragement to raise test coverage!
@JoshuaKGoldberg JoshuaKGoldberg added area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups labels Jan 6, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jan 6, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 6, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Jan 6, 2024
@JoshuaKGoldberg
test: added end-to-end-style unit test (#205)
6d731ee 
## PR Checklist

- [x] Addresses an existing open issue: fixes #204
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/all-contributors-for-repository/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/all-contributors-for-repository/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Adds a "unit" test that acts more as an end-to-end test. It mocks out
the GitHub API and calls to the root-exported
`getAllContributorsForRepository`.

Raises line coverage to near-100%, though it does miss a few bits of
branch coverage. I don't feel motivated to really dive in and get true
100% branch/conditional/etc. coverage myself. That's fine as followup
good first issues if anybody wants to ramp up on contributing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: added end-to-end-style unit test JoshuaKGoldberg/all-contributors-for-repository
1 participant
@JoshuaKGoldberg