test: added end-to-end-style unit test #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
===========================================
+ Coverage 75.19% 99.80% +24.60%
===========================================
Files 17 17
Lines 512 512
Branches 24 29 +5
===========================================
+ Hits 385 511 +126
+ Misses 127 1 -126 ☔ View full report in Codecov by Sentry. |
|
@all-contributors please add @JoshuaKGoldberg for test.
|
|
I've put up a pull request to add @JoshuaKGoldberg! 🎉 I couldn't determine any contributions to add, did you specify any contributions? |
JoshuaKGoldberg
pushed a commit
that referenced
this pull request
Jan 6, 2024
Adds @JoshuaKGoldberg as a contributor for test. This was requested by JoshuaKGoldberg [in this comment](#205 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Adds a "unit" test that acts more as an end-to-end test. It mocks out the GitHub API and calls to the root-exported
getAllContributorsForRepository.Raises line coverage to near-100%, though it does miss a few bits of branch coverage. I don't feel motivated to really dive in and get true 100% branch/conditional/etc. coverage myself. That's fine as followup good first issues if anybody wants to ramp up on contributing.