fix: directly query npm instead of via npms #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
==========================================
+ Coverage 95.62% 95.94% +0.31%
==========================================
Files 12 12
Lines 343 370 +27
Branches 30 30
==========================================
+ Hits 328 355 +27
Misses 15 15 ☔ View full report in Codecov by Sentry. |
3 tasks
JoshuaKGoldberg
added a commit
to JoshuaKGoldberg/tidelift-me-up-site
that referenced
this pull request
Dec 14, 2023
## PR Checklist - [x] Addresses an existing open issue: fixes #000 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/tidelift-me-up-site/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/tidelift-me-up-site/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Brings in JoshuaKGoldberg/tidelift-me-up#186, which fixed JoshuaKGoldberg/tidelift-me-up#185.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Switches to the npm API. The
PackageDatastructure seems to be just about the same as npms, which makes this pretty much not a breaking change. Yay!Example base query for searching: https://registry.npmjs.com/-/v1/search?&text=maintainer:joshuakgoldberg