🥊 Glue auth components #4282
🥊 Glue auth components #4282
Conversation
There was a problem hiding this comment.
Amazing work with gluing this together. I managed to create a channel and post a video without using any extension 🤯 . Some things that I found when I was testing this:
-
I already told you about this on discord, but I'll post this here as well. Deployment preview is not working because we're getting error from polkadot
-
I think I broke this, but there are dividers in a few modal, and they shouldn't be here
-
I didn't go any errors when I used email that is already used in this step:
-
I don't think we should show the error-type snackbar.
Please check what we have currently:
-
Once I created a video without extension and transaction modal disappeared I didn't have a new video in my videos. It seems that we didn't refetch user videos.
-
I'm experiencing multiple redirects when I refresh the studio(signed user with extension)
Nagranie.z.ekranu.2023-06-6.o.09.42.28.mov
- Once you switch the channel to a member there is a weird gap in the member dropdown
EDIT - Actually I can't reproduce this anymore, so possibly this can be ignored.
- Once I signed up I wasn't automatically logged in.
I'm fine if we do these fixes in follow-up PRs, please create issues on GH if you feel that we should tackle these separately.
| return <SignUpModal /> | ||
| default: | ||
| return null | ||
| } |
There was a problem hiding this comment.
Because of this switch statement once you close the modal there is no ending transition animation. The modal closes immediately.
packages/atlas/src/components/_auth/ExternalSignInModal/ExternalSignInModal.tsx
Outdated
Show resolved
Hide resolved
packages/atlas/src/components/_overlays/MemberDropdown/MemberDropdownNav.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Few bugs:
-
If a user provides an email that already exists, and then corrects the email and signs up again, he won’t be logged in automatically after signing up a second time
-
found another redirecting bug. Steps to reproduce:
- log into your account using your wallet. The account needs to have a channel
- Go to the studio
- Logout
- Click login CTA
- Use a different account that doesn’t have a channel
- The app is constantly redirecting from studio to sign-in, and I’m ending up in an infinite loop of redirecting
I think we don’t clear the channelId from local storage after logging out. This could be a reason
- You forgot to add a handler to this button
* Add correct flows between auth modals * Initial work on internal login * external login * Further work on ExternalSignInModal * Fix sometimes incorrect type * Fix minor issues when switching from internal to external login in one session * Fix loading issue * Resolve todos * Unmount auth modals when not needed * Re export * fix dividers issue * CR fixes v1 * Fix circular deps * Login after signup * Lint * CR fixes v2 --------- Co-authored-by: drillprop <drylbartosz@gmail.com>
* anonymous user interaction (#4168) * 🔑 Protected actions (#4164) * 🔐 Login modal (#4182) * Sign up flow (#4210) * 🤯 External wallet login (#4252) * 🌳 Rearrange user, wallet, and auth provider (#4260) * Public profile settings (#4275) * 🥊 Glue auth components (#4282) * 🩹 My channel (#4329) * 🦢 Swap sign up step (#4317) * 🧠 Forgot password flow (#4325) * 🌵 Channel creation modal (#4334) * 🐉 Dropdown rework (#4337) * Wallet settings, change password and download mnemonic (#4326) * Update packages/atlas/src/views/viewer/MembershipSettingsView/MembershipWallet/MembershipWallet.tsx * Simplified ypp sign up (#4351) * 👯♀️ Account followup fixes (#4394) --------------------- Co-authored-by: Bartosz Dryl <drylbartosz@gmail.com> Co-authored-by: WRadoslaw <92513933+WRadoslaw@users.noreply.github.com> Co-authored-by: Artem Slugin <attemka@gmail.com>
#4263