Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet settings, change password and download mnemonic #4326

Merged
merged 27 commits into from
Jun 30, 2023
Merged

Wallet settings, change password and download mnemonic #4326

merged 27 commits into from
Jun 30, 2023

Conversation

drillprop
Copy link
Contributor

@drillprop drillprop commented Jun 13, 2023 •
edited
Loading

Fix #4243 #4319

@drillprop drillprop requested review from attemka and WRadoslaw June 13, 2023 13:02
@drillprop drillprop marked this pull request as draft June 14, 2023 07:05
@drillprop drillprop marked this pull request as ready for review June 14, 2023 12:32
attemka
attemka requested changes Jun 14, 2023
View reviewed changes
Copy link
Collaborator

@attemka attemka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very nice. Only minor things to change

packages/atlas/src/components/_auth/PasswordCriterias/PasswordCriterias.tsx Outdated Show resolved Hide resolved
packages/atlas/src/views/viewer/MembershipSettingsView/ChangePasswordDialog.tsx Outdated Show resolved Hide resolved
packages/atlas/src/views/viewer/MembershipSettingsView/ChangePasswordDialog.tsx Outdated Show resolved Hide resolved
packages/atlas/src/views/viewer/MembershipSettingsView/MembershipWallet/MembershipWallet.tsx Outdated Show resolved Hide resolved
drillprop and others added 2 commits June 15, 2023 09:03
@drillprop
cr fixes
7d061d0
@drillprop @attemka
Update packages/atlas/src/views/viewer/MembershipSettingsView/Members…
8f252a0 
…hipWallet/MembershipWallet.tsx

Co-authored-by: attemka <attemka@gmail.com>
@drillprop drillprop requested a review from attemka June 15, 2023 07:05
WRadoslaw
WRadoslaw suggested changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@WRadoslaw WRadoslaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. After changing my avatar I got redirected, but my membership was not refetched.
    image
    The same thing applies for handle change, but since we use it in URL params after F5 is receive empty page
    image

  2. We display tx fee even tho nothing was changed (public profile tab)
    image

  3. Why do we need action bar in wallet tab if every action performed in this tab is performed inside a specific dialog?

  4. @dmtrjsg @attemka I know that it's possible for someone determined to retrieve a mnemonic (with local storage) after the user forgot to log out or smth to do it. But having password auth for seed export and right under its action to change the password without knowing the previous one is pointless.

packages/atlas/src/views/viewer/MembershipSettingsView/ChangePasswordDialog.tsx Outdated Show resolved Hide resolved
packages/atlas/src/views/viewer/MembershipSettingsView/ChangePasswordDialog.tsx Outdated Show resolved Hide resolved
packages/atlas/src/views/viewer/MembershipSettingsView/ExportSeedDialog.tsx Show resolved Hide resolved
packages/atlas/src/views/viewer/MembershipSettingsView/ExportSeedDialog.tsx Outdated Show resolved Hide resolved
packages/atlas/src/views/viewer/MembershipSettingsView/ExportSeedDialog.tsx Show resolved Hide resolved
@dmtrjsg
Copy link

dmtrjsg commented Jun 20, 2023

@KubaMikolajczyk

  1. We don't need publish/ cancel on the wallet tab as there are no inputs to change on the actual page?
  2. Do we want to add "back to profile"? As there is no way to go back now (cancel button is wired to do it but feels suboptimal)
  3. The cancel button is only valid if you edit smth but shown always?

The argument is to show the bottom panel only on change of inputs.. wdyt?

@KubaMikolajczyk
Copy link
Collaborator

@dmtrjsg implemented solutions for your feedback above. Edited few components and added documentation for action bar behavior logic. Also all of the pages are now updated with the new logic.
🎥 Loom update: https://www.loom.com/share/00925d975de8440cb3c1b649d9885764?sid=41b52e4a-ee96-45ae-acfd-0392018758fa
📄 Membership profile changelog: https://www.figma.com/file/yhZpTHdf1sxJx13uRZ71GV/Membership-profile?type=design&node-id=2912-46498&t=NL8Mje6NhP5iQSJu-4
📄 My channel profile changelog: https://www.figma.com/file/zi5siPUXme0Fivq2i40XBd/My-channel?type=design&node-id=703-5383&mode=design&t=ahFXFmRVHCGuSKja-4

@drillprop drillprop marked this pull request as draft June 22, 2023 12:13
@drillprop
Copy link
Contributor Author

Draft, I need to apply new action bar changes

@drillprop drillprop marked this pull request as ready for review June 26, 2023 13:39
WRadoslaw
WRadoslaw suggested changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@WRadoslaw WRadoslaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. If we change any field in public profile tab and reverse it the fee will not zero out
    image

  2. I cannot change password
    image

packages/atlas/src/views/viewer/MembershipSettingsView/ChangePasswordDialog.tsx Outdated Show resolved Hide resolved
packages/atlas/src/views/viewer/MembershipSettingsView/ChangePasswordDialog.tsx Outdated
confirmPassword: string
}

export const getMnemonicFromeEmailAndPassword = async (email: string, password: string) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have anything similar in auth provder helpers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't but I moved the function to helpers

@drillprop drillprop requested a review from WRadoslaw June 27, 2023 06:33
@drillprop
Copy link
Contributor Author

  1. If we change any field in public profile tab and reverse it the fee will not zero out
    image

Fixed

  1. I cannot change the password
    image

I wasn't able to reproduce it, but I used the same timestamp logic that we have in the login and signup functions, so hopefully, it will be fine now.

@attemka attemka merged commit 8da91b9 into Joystream:accounts Jun 30, 2023
attemka added a commit to attemka/atlas that referenced this pull request Jul 5, 2023
@drillprop @attemka
Wallet settings, change password and download mnemonic (Joystream#4326)
7135913 
* wip

* settings view ground work

* uncomment route

* add borderColor prop to banner

* fix issues with modal paddings

* create password form component, sign up modal refactoring

* add export seed dialog and change password dialog

* handle copy button

* show different settings for wallet users

* refactor password dialogs

* cr fixes

* Update packages/atlas/src/views/viewer/MembershipSettingsView/MembershipWallet/MembershipWallet.tsx

Co-authored-by: attemka <attemka@gmail.com>

* auth helpers further refactor

* reset form on cancel

* cr fixes

* cr fixes 2

* add additional step to ChangePassword

* action bar adjustments, add unsaved changes dialog

* fix viewer layout

* action bar changes

* action bar adjustments

* cr fixes

* fix fee issue

* change password fix?

---------

Co-authored-by: attemka <attemka@gmail.com>
attemka added a commit that referenced this pull request Jul 6, 2023
@attemka
Merge 'Accounts' into 'dev' (#4398)
641ec80 
* anonymous user interaction (#4168)

* 🔑 Protected actions (#4164)

* 🔐 Login modal (#4182)

* Sign up flow (#4210)

* 🤯 External wallet login (#4252)

* 🌳 Rearrange user, wallet, and auth provider (#4260)

* Public profile settings (#4275)

* 🥊 Glue auth components (#4282)

* 🩹 My channel (#4329)

* 🦢 Swap sign up step (#4317)

* 🧠 Forgot password flow (#4325)

* 🌵 Channel creation modal (#4334)

* 🐉 Dropdown rework (#4337)

* Wallet settings, change password and download mnemonic (#4326)

* Update packages/atlas/src/views/viewer/MembershipSettingsView/MembershipWallet/MembershipWallet.tsx

* Simplified ypp sign up (#4351)

* 👯‍♀️ Account followup fixes (#4394)

---------------------
Co-authored-by: Bartosz Dryl <drylbartosz@gmail.com>
Co-authored-by: WRadoslaw <92513933+WRadoslaw@users.noreply.github.com>
Co-authored-by: Artem Slugin <attemka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WRadoslaw WRadoslaw WRadoslaw approved these changes

@attemka attemka Awaiting requested review from attemka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@drillprop @dmtrjsg @KubaMikolajczyk @attemka @WRadoslaw