🐕 Feature/husky implementation (#2851)

* husky added

* additional rule added

* new rule

* additional rule

* html added

* test lint

* new rules added

* Optimize tsconfig

* Run eslint first

* Fix the typescript config

Co-authored-by: tomekstepien <tomasz.stepien@elliptic.co>
Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>

.husky/.gitignore

@@ -0,0 +1 @@
+_

.husky/pre-commit

@@ -0,0 +1,4 @@
+#!/bin/sh
+. "$(dirname "$0")/_/husky.sh"
+
+npx lint-staged

package.json

@@ -11,20 +11,24 @@
     ]
   },
   "scripts": {
-    "lint": "wsrun --package ui -c lint",
+    "lint": "wsrun --package ui -c lint:fix",
     "build": "wsrun --fast-exit --stages -c --exclude @joystream/markdown-editor build",
     "build:storybook": "wsrun --fast-exit --stages -c --exclude ui --exclude-missing build && wsrun --package ui -c build:storybook",
     "storybook": "wsrun --exclude-missing -c storybook",
     "test": "wsrun --fast-exit --package ui -c test",
     "ci-test": "NODE_OPTIONS=--max_old_space_size=7000 wsrun --fast-exit --package ui -c test",
-    "start": "wsrun --package ui -c start"
+    "start": "wsrun --package ui -c start",
+    "prepare": "husky install"
   },
   "dependencies": {
     "eslint-plugin-import": "^2.23.4",
     "wsrun": "^5.2.4"
   },
   "devDependencies": {
-    "eslint": "^7.29.0"
+    "@typescript-eslint/parser": "^5.19.0",
+    "eslint": "^7.29.0",
+    "husky": ">=6",
+    "lint-staged": ">=10"
   },
   "resolutions": {
     "@polkadot/api": "5.9.1",
@@ -47,5 +51,11 @@
   "engines": {
     "node": ">=14.0.0",
     "yarn": "^1.22.0"
+  },
+  "lint-staged": {
+    "packages/ui/src/**/*.{js,ts,tsx,html}": [
+      "eslint --fix",
+      "prettier --write"
+    ]
   }
 }

packages/ui/package.json

@@ -102,7 +102,6 @@
     "@types/mime": "^2.0.3",
     "@types/yargs": "^17.0.3",
     "@typescript-eslint/eslint-plugin": "^4.33.0",
-    "@typescript-eslint/parser": "^4.33.0",
     "babel": "^6.23.0",
     "babel-jest": "^27.2.5",
     "babel-loader": "^8.2.2",

packages/ui/src/working-groups/modals/LeaveRoleModal/LeaveRoleSignModal.tsx

@@ -31,7 +31,6 @@ export const LeaveRoleSignModal = ({ onClose, transaction, worker, service }: Pr
     signer: signer?.address ?? '',
     service,
   })
-
   return (
     <TransactionModal service={service} onClose={onClose}>
       <ModalBody>

packages/ui/tsconfig.json

@@ -1,23 +1,12 @@
 {
-  "ts-node": {
-    "files": false
-  },
+  "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "target": "es2020",
-    "module": "commonjs",
-    "sourceMap": true,
-    "strict": true,
-    "esModuleInterop": true,
-    "resolveJsonModule": true,
-    "skipLibCheck": true,
-    "jsx": "react",
-    "lib": ["DOM", "ES2020"],
-    "types": ["jest"],
+    "baseUrl": ".",
     "paths": {
       "@/*": ["src/*"],
       "@polkadot/api/augment": ["../types/augment/augment-api.ts"],
       "@polkadot/types/augment": ["../types/augment/augment-types.ts"]
     },
-    "baseUrl": "."
-  }
+  },
+  "include": ["dev", "src", "test"],
 }

tsconfig.json

@@ -0,0 +1,19 @@
+{
+  "ts-node": {
+    "files": false
+  },
+  "compilerOptions": {
+    "target": "es2020",
+    "module": "commonjs",
+    "sourceMap": true,
+    "strict": true,
+    "esModuleInterop": true,
+    "resolveJsonModule": true,
+    "skipLibCheck": true,
+    "jsx": "react",
+    "lib": ["DOM", "ES2020"],
+    "types": ["jest"],
+    "baseUrl": "."
+  },
+  "exclude": ["**/node_modules"]
+}