Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐕 Feature/husky implementation #2851

Merged
merged 10 commits into from
Apr 15, 2022
Merged

Conversation

stepien4soft
Copy link
Contributor

Close: #2803 #2805

@vercel
Copy link

vercel bot commented Apr 12, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

pioneer-2 – ./

🔍 Inspect: https://vercel.com/joystream/pioneer-2/7bBZuNaA5U1S5Q6zMNaJkpsiEWuj
✅ Preview: https://pioneer-2-git-feature-husky-implementation-joystream.vercel.app

pioneer-2-storybook – ./

🔍 Inspect: https://vercel.com/joystream/pioneer-2-storybook/EcBdHB2eGMjAmk5xPMmb95jY4NtW
✅ Preview: https://pioneer-2-storybook-git-feature-husky-implementation-joystream.vercel.app

dao – ./

🔍 Inspect: https://vercel.com/joystream/dao/GJKuiah8bhUDkqZdi8fxcNpF8T51
✅ Preview: https://dao-git-feature-husky-implementation-joystream.vercel.app

[Deployment for bf8c44e failed]

Copy link
Collaborator

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me the yarn lint script is run entirely which takes ~2min
Screenshot from 2022-04-13 12-29-07
Doesn't it need the command to accept the modified files as arguments ?

Also does it works as expected on macOS ?

Finally it would be great if you could add the index.html in there as it's the only file my IDE can't format properly 😞 (if it's not worth spending too long on this though).

@thesan thesan changed the title 👀 Feature/husky implementation 🐕 Feature/husky implementation Apr 15, 2022
@thesan thesan closed this Apr 15, 2022
@thesan thesan reopened this Apr 15, 2022
@stepien4soft stepien4soft merged commit 5a1776d into dev Apr 15, 2022
@stepien4soft stepien4soft deleted the feature/husky-implementation branch April 15, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Husky
4 participants