-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐕 Feature/husky implementation #2851
Conversation
This pull request is being automatically deployed with Vercel (learn more). pioneer-2 – ./🔍 Inspect: https://vercel.com/joystream/pioneer-2/7bBZuNaA5U1S5Q6zMNaJkpsiEWuj pioneer-2-storybook – ./🔍 Inspect: https://vercel.com/joystream/pioneer-2-storybook/EcBdHB2eGMjAmk5xPMmb95jY4NtW dao – ./🔍 Inspect: https://vercel.com/joystream/dao/GJKuiah8bhUDkqZdi8fxcNpF8T51 [Deployment for bf8c44e failed] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me the yarn lint
script is run entirely which takes ~2min
Doesn't it need the command to accept the modified files as arguments ?
Also does it works as expected on macOS ?
Finally it would be great if you could add the index.html
in there as it's the only file my IDE can't format properly 😞 (if it's not worth spending too long on this though).
ac49c0e
to
4981b1e
Compare
4981b1e
to
cd22a4c
Compare
cd22a4c
to
78fad2a
Compare
Close: #2803 #2805