Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateMembership #3133

Closed
2 tasks
ivanturlakov opened this issue May 31, 2022 · 4 comments · Fixed by #3773 or #3956
Closed
2 tasks

UpdateMembership #3133

ivanturlakov opened this issue May 31, 2022 · 4 comments · Fixed by #3773 or #3956
Assignees
Labels
bug Something isn't working community-dev issue suitable for community-dev pipeline qa-task qa-tested-ready-for-prod release:0.1.1 release:1.2.0 scope:members The "Members" page and related features SP:3

Comments

@ivanturlakov
Copy link

ivanturlakov commented May 31, 2022

Scope

  • Add refetching of Membership details on side panel (on the left)
  • and MemberId in the membership module

Some frontend items(marked red) did not update after the transaction was executed.

Member choosed for editing
Снимок экрана 2022-05-26 в 14 14 04

Editing
Снимок экрана 2022-05-26 в 14 15 03

Frontend after editing. The fields marked in red were not updated untill page refreshed.
Снимок экрана 2022-05-26 в 14 20 27

Transaction details
Снимок экрана 2022-05-26 в 14 22 01

@ivanturlakov ivanturlakov added the bug Something isn't working label May 31, 2022
@dmtrjsg dmtrjsg added scope:members The "Members" page and related features query-node bug caused by query node defects to-triage community-dev issue suitable for community-dev pipeline SP:3 and removed query-node bug caused by query node defects to-triage labels Jun 6, 2022
@traumschule
Copy link
Collaborator

From my research to update the left sidepane call setActive(member) on state.machine('success')

// memberships/modals/UpdateMembershipModal/UpdateMembershipModal.tsx
import { useMyMemberships } from '../../hooks/useMyMemberships' 
const { members, setActive, active } = useMyMemberships()

...

if (state.matches('success')) {
  setActive(member) // <-- here
  return <UpdateMembershipSuccessModal onClose={hideModal} member={member} />

This should automatically update My Profile as well.

Just confirming there's no better way, @dmtrjsg @thesan

@dmtrjsg
Copy link
Contributor

dmtrjsg commented Oct 28, 2022

@traumschule Hey will be okay to go like that 👌 , thanks for driving it by us!

traumschule pushed a commit to traumschule/pioneer that referenced this issue Oct 30, 2022
thesan pushed a commit that referenced this issue Nov 17, 2022
* Update Sidebar membership display after edit tx (#3133)

* remove unused variables

Co-authored-by: Joystream Stats <dev@joystreamstats.live>
@thesan thesan reopened this Nov 17, 2022
@ivanturlakov
Copy link
Author

Tested on https://dao-git-dev-joystream.vercel.app/#/profile/memberships
wss://34.230.5.182.nip.io/ws-rpc

You still need to refresh the page to see the changed data

2022-12-03.18.50.57.mov

@ivanturlakov
Copy link
Author

✅ Tested on https://dao-git-dev-joystream.vercel.app/#/profile/memberships
wss://34.230.5.182.nip.io/ws-rpc

All items were updated successfully

2022-12-22.12.40.37.mov

XxFlameCatxX pushed a commit to XxFlameCatxX/pioneer that referenced this issue Dec 27, 2022
…stream#3773)

* Update Sidebar membership display after edit tx (Joystream#3133)

* remove unused variables

Co-authored-by: Joystream Stats <dev@joystreamstats.live>
XxFlameCatxX pushed a commit to XxFlameCatxX/pioneer that referenced this issue Jan 14, 2023
…stream#3773)

* Update Sidebar membership display after edit tx (Joystream#3133)

* remove unused variables

Co-authored-by: Joystream Stats <dev@joystreamstats.live>
XxFlameCatxX pushed a commit to XxFlameCatxX/pioneer that referenced this issue Jan 14, 2023
…stream#3773)

* Update Sidebar membership display after edit tx (Joystream#3133)

* remove unused variables

Co-authored-by: Joystream Stats <dev@joystreamstats.live>
XxFlameCatxX pushed a commit to XxFlameCatxX/pioneer that referenced this issue Jan 14, 2023
…stream#3773)

* Update Sidebar membership display after edit tx (Joystream#3133)

* remove unused variables

Co-authored-by: Joystream Stats <dev@joystreamstats.live>
@thesan thesan closed this as completed Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community-dev issue suitable for community-dev pipeline qa-task qa-tested-ready-for-prod release:0.1.1 release:1.2.0 scope:members The "Members" page and related features SP:3
Projects
None yet
5 participants