-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Sidebar membership display after edit tx (#3133) #3773
Merged
thesan
merged 2 commits into
Joystream:dev
from
traumschule:fix/update-on-edit-membership-3133
Nov 17, 2022
Merged
Update Sidebar membership display after edit tx (#3133) #3773
thesan
merged 2 commits into
Joystream:dev
from
traumschule:fix/update-on-edit-membership-3133
Nov 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
traumschule
added
community-dev
issue suitable for community-dev pipeline
jsg-code-review
labels
Oct 30, 2022
thesan
requested changes
Nov 3, 2022
import { updateMembershipMachine } from './machine' | ||
import { UpdateMembershipFormModal } from './UpdateMembershipFormModal' | ||
import { UpdateMembershipSuccessModal } from './UpdateMembershipSuccessModal' | ||
|
||
export const UpdateMembershipModal = () => { | ||
const { api } = useApi() | ||
const { members, setActive, active } = useMyMemberships() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove unused variables:
Suggested change
const { members, setActive, active } = useMyMemberships() | |
const { setActive } = useMyMemberships() |
thesan
approved these changes
Nov 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
XxFlameCatxX
pushed a commit
to XxFlameCatxX/pioneer
that referenced
this pull request
Dec 27, 2022
…stream#3773) * Update Sidebar membership display after edit tx (Joystream#3133) * remove unused variables Co-authored-by: Joystream Stats <dev@joystreamstats.live>
XxFlameCatxX
pushed a commit
to XxFlameCatxX/pioneer
that referenced
this pull request
Jan 14, 2023
…stream#3773) * Update Sidebar membership display after edit tx (Joystream#3133) * remove unused variables Co-authored-by: Joystream Stats <dev@joystreamstats.live>
XxFlameCatxX
pushed a commit
to XxFlameCatxX/pioneer
that referenced
this pull request
Jan 14, 2023
…stream#3773) * Update Sidebar membership display after edit tx (Joystream#3133) * remove unused variables Co-authored-by: Joystream Stats <dev@joystreamstats.live>
XxFlameCatxX
pushed a commit
to XxFlameCatxX/pioneer
that referenced
this pull request
Jan 14, 2023
…stream#3773) * Update Sidebar membership display after edit tx (Joystream#3133) * remove unused variables Co-authored-by: Joystream Stats <dev@joystreamstats.live>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #3133