Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sidebar membership display after edit tx (#3133) #3773

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

traumschule
Copy link
Collaborator

Fixed #3133

@vercel
Copy link

vercel bot commented Oct 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dao ✅ Ready (Inspect) Visit Preview Nov 4, 2022 at 6:05PM (UTC)
pioneer-2 ✅ Ready (Inspect) Visit Preview Nov 4, 2022 at 6:05PM (UTC)
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Nov 4, 2022 at 6:05PM (UTC)

import { updateMembershipMachine } from './machine'
import { UpdateMembershipFormModal } from './UpdateMembershipFormModal'
import { UpdateMembershipSuccessModal } from './UpdateMembershipSuccessModal'

export const UpdateMembershipModal = () => {
const { api } = useApi()
const { members, setActive, active } = useMyMemberships()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unused variables:

Suggested change
const { members, setActive, active } = useMyMemberships()
const { setActive } = useMyMemberships()

Copy link
Collaborator

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thesan thesan merged commit 5cab9bf into Joystream:dev Nov 17, 2022
XxFlameCatxX pushed a commit to XxFlameCatxX/pioneer that referenced this pull request Dec 27, 2022
…stream#3773)

* Update Sidebar membership display after edit tx (Joystream#3133)

* remove unused variables

Co-authored-by: Joystream Stats <dev@joystreamstats.live>
XxFlameCatxX pushed a commit to XxFlameCatxX/pioneer that referenced this pull request Jan 14, 2023
…stream#3773)

* Update Sidebar membership display after edit tx (Joystream#3133)

* remove unused variables

Co-authored-by: Joystream Stats <dev@joystreamstats.live>
XxFlameCatxX pushed a commit to XxFlameCatxX/pioneer that referenced this pull request Jan 14, 2023
…stream#3773)

* Update Sidebar membership display after edit tx (Joystream#3133)

* remove unused variables

Co-authored-by: Joystream Stats <dev@joystreamstats.live>
XxFlameCatxX pushed a commit to XxFlameCatxX/pioneer that referenced this pull request Jan 14, 2023
…stream#3773)

* Update Sidebar membership display after edit tx (Joystream#3133)

* remove unused variables

Co-authored-by: Joystream Stats <dev@joystreamstats.live>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-dev issue suitable for community-dev pipeline jsg-code-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UpdateMembership
2 participants