Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sidebar membership display after edit tx (#3133) #3773

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Update Sidebar membership display after edit tx (#3133) #3773

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbe0065
Update Sidebar membership display after edit tx (#3133)
Oct 30, 2022
93c1bd9
remove unused variables
Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/ui/src/memberships/modals/UpdateMembershipModal/UpdateMembershipModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,15 @@ import { SignTransactionModal } from '@/common/modals/SignTransactionModal/SignT
import { UpdateMembershipModalCall } from '@/memberships/modals/UpdateMembershipModal/index'
import { createBatch } from '@/memberships/modals/UpdateMembershipModal/utils'

import { useMyMemberships } from '../../hooks/useMyMemberships'

import { updateMembershipMachine } from './machine'
import { UpdateMembershipFormModal } from './UpdateMembershipFormModal'
import { UpdateMembershipSuccessModal } from './UpdateMembershipSuccessModal'

export const UpdateMembershipModal = () => {
const { api } = useApi()
const { members, setActive, active } = useMyMemberships()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unused variables:

Suggested change
const { members, setActive, active } = useMyMemberships()
const { setActive } = useMyMemberships()

const {
hideModal,
modalData: { member },
Expand Down Expand Up @@ -44,6 +47,7 @@ export const UpdateMembershipModal = () => {
}

if (state.matches('success')) {
setActive(member)
return <UpdateMembershipSuccessModal onClose={hideModal} member={member} />
}

Expand Down