Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Joystream Pioneer Forum Back Link #3768

Closed
1 task
Songoku1691 opened this issue Oct 28, 2022 · 4 comments
Closed
1 task

Joystream Pioneer Forum Back Link #3768

Songoku1691 opened this issue Oct 28, 2022 · 4 comments
Assignees
@vrrayz
Labels
community-dev issue suitable for community-dev pipeline enhancement New feature or request jsg-code-review low-risk qa-tested-ready-for-prod release:1.3.1 scope:forum The "Forum" page and related features SP:2

Comments

@Songoku1691
Copy link

Songoku1691 commented Oct 28, 2022 •
edited by dmtrjsg
Loading

Scope

  • Add page number to the url so "back" in-app button brings to the right previous page in case of paginated prev page.

Context

Hello Guys;

I observed a limitation in Joystream Pioneer Forum. I'm not sure if it's a bug (not working) or improvement (no feature of this function).
Please see this Atlas video: https://play.joystream.org/video/27767

You will notice I clicked a forum thread on Page 9 of a Category. When I clicked back, I assumed I would go back to Page 9 of Category. Instead, I was brought to Page 1. So if I want to check the next thread on that page, I will need to click again Page 9.

I hope I explained it well.

Thank you
@Songoku1691 Songoku1691 added the enhancement New feature or request label Oct 28, 2022
@dmtrjsg dmtrjsg added scope:forum The "Forum" page and related features to-triage labels Oct 28, 2022
@dmtrjsg
Copy link
Contributor

dmtrjsg commented Oct 28, 2022

Thanks you've explained it very well and extra points for the nice music 😄 I agree this is pretty annoying for a heavy Forum user..

@dmtrjsg dmtrjsg added the community-dev issue suitable for community-dev pipeline label Oct 28, 2022
@dmtrjsg dmtrjsg added the SP:2 label Oct 28, 2022
@traumschule traumschule mentioned this issue Oct 30, 2022
Closed
@vrrayz
Copy link
Contributor

vrrayz commented Nov 3, 2022 •
edited
Loading

I'd like to take this up as well. I just dropped a fix for #2977 in this PR here

@vrrayz vrrayz mentioned this issue Feb 6, 2023
Merged
@vrrayz
Copy link
Contributor

vrrayz commented Feb 6, 2023

I just fixed this here #4147

thesan pushed a commit that referenced this issue Mar 3, 2023
@vrrayz
Fixed Joystream Pioneer Forum Back Link #3768 (#4147)
0e35241 
* Fixed pagination back link using a custom hook

* Set back to default

* refactored custom hook

* Thread redirect when page exceeds count

* Removed extra changes
@ivanturlakov
Copy link

✅ Tested on https://dao-git-dev-joystream.vercel.app/#/forum/category/1

This case works as expected

2023-03-05.16.25.40.mov

Also, I found another scenario with "back btn" bug #4215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrrayz vrrayz

Labels
community-dev issue suitable for community-dev pipeline enhancement New feature or request jsg-code-review low-risk qa-tested-ready-for-prod release:1.3.1 scope:forum The "Forum" page and related features SP:2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@thesan @traumschule @vrrayz @ivanturlakov @dmtrjsg @chrlschwb @Songoku1691