Issue 2977

[vrrayz]

Back button on openings now list to list page as requested from this this issue

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
dao	✅ Ready (Inspect)	Visit Preview	Dec 13, 2022 at 1:22AM (UTC)
pioneer-2	✅ Ready (Inspect)	Visit Preview	Dec 13, 2022 at 1:22AM (UTC)
pioneer-2-storybook	✅ Ready (Inspect)	Visit Preview	Dec 13, 2022 at 1:22AM (UTC)

[traumschule]

LGTM! Keep on it with #3768 if you want.

[WRadoslaw]

LGTM!

[WRadoslaw]

Actually, I just noticed that this solution causes one bug. Problem is that when you go into opening details from a specific WG page, the back button will always transfer you to general openings instead of given WG ones.

Two cases have to be considered before pushing customLink to the stack:

• Whether history.length is bigger than 2 (if stack eq 1 then, the user clicks the link and get redirected, if stack eq 2 there is a possibility that the user opened a new tab in the browser and paste in the link
• Another possibility is that the user clicks on the URL to the openings list and then clicks on the given opening, in that case, checking for stack length will fail (stack length will equal 2, but goBack should be invoked anyway), but we can check the current action on the history. I see that when you paste the URL or click on the link action will eq POP while if you navigate from Pioneer forward (Opening list -> Opening details) it will be PUSH

Integrating these two rules should do the work. WDYT?

[vrrayz]

Actually, I just noticed that this solution causes one bug. Problem is that when you go into opening details from a specific WG page, the back button will always transfer you to general openings instead of given WG ones.

Two cases have to be considered before pushing customLink to the stack:

• Whether history.length is bigger than 2 (if stack eq 1 then, the user clicks the link and get redirected, if stack eq 2 there is a possibility that the user opened a new tab in the browser and paste in the link
• Another possibility is that the user clicks on the URL to the openings list and then clicks on the given opening, in that case, checking for stack length will fail (stack length will equal 2, but goBack should be invoked anyway), but we can check the current action on the history. I see that when you paste the URL or click on the link action will eq POP while if you navigate from Pioneer forward (Opening list -> Opening details) it will be PUSH

Integrating these two rules should do the work. WDYT?

I just made modifications based on your second suggestion. I think tracking the link action is all that's needed. I tested out for those cases you mentioned, and they work fine now

[traumschule]

lgtm! tested entering opening details from /working-groups/openings and /working-groups/forum.

[oleksanderkorn]

Why does it have all the types changes here? I guess this can be done in a separate change if needed.

[traumschule]

You are right, didn't look at the code. @vrrayz resubmit the fix on a new branch please.

[vrrayz]

You are right, didn't look at the code. @vrrayz resubmit the fix on a new branch please.

alright

[vrrayz]

@traumschule I just resubmitted in this branch