Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed back link issue on opening with empty referrer #3981

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

vrrayz
Copy link
Contributor

@vrrayz vrrayz commented Dec 14, 2022

Back button on openings now list to list page as requested from this #2977

@traumschule @oleksanderkorn

@vercel
Copy link

vercel bot commented Dec 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dao ✅ Ready (Inspect) Visit Preview Dec 17, 2022 at 10:59PM (UTC)
pioneer-2 ✅ Ready (Inspect) Visit Preview Dec 17, 2022 at 10:59PM (UTC)
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Dec 17, 2022 at 10:59PM (UTC)

Copy link
Collaborator

@traumschule traumschule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested here

@vercel
Copy link

vercel bot commented Dec 17, 2022

@vrrayz is attempting to deploy a commit to the joystream Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks that's a great solution 🙌

@thesan thesan merged commit b9e887b into Joystream:dev Dec 20, 2022
XxFlameCatxX pushed a commit to XxFlameCatxX/pioneer that referenced this pull request Jan 14, 2023
* Fixed back link issue on opening with empty referrer

* Made suggested fix on non null assertion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-dev issue suitable for community-dev pipeline jsg-code-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants