Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Past Election Blocktime tooltip #4156

Closed
traumschule opened this issue Feb 8, 2023 · 2 comments
Closed

Remove Past Election Blocktime tooltip #4156

traumschule opened this issue Feb 8, 2023 · 2 comments
Labels
community-dev issue suitable for community-dev pipeline enhancement New feature or request qa-task scope:proposals The "Proposals" page and related features SP:2

Comments

@traumschule
Copy link
Collaborator

Follow-up to #3808 (#3168):

About the BlockInfo it's good to show "Block 1000" instead of "1000 Block". But since the network information is out of date (it should have been removed on the QN) I don't think there's a point having a tooltip here. This component should stick to the design. In addition lessInfo should be removed from the code. Finally maybe maybe the Link component could have a click handler with event.stopPropagation() but that's not very urgent (even now it's possible to right click "Open link in New Tab" to open the link.
@traumschule traumschule added enhancement New feature or request design Description of a feature scope or detailed requirements scope:council labels Feb 8, 2023
@dmtrjsg
Copy link
Contributor

dmtrjsg commented Feb 10, 2023 •
edited
Loading

⚠️ for the past Elections case let's use original PR referenced in the description.

  1. Remove block tooltip
    Past elections

Screenshot 2023-02-10 at 15 40 14

2. Upon hover show block/date as clickable 3. Upon click open block explorer in the new tab

SCOPE OF THIS ISSUE:
For Proposals > history

Screenshot 2023-02-10 at 15 40 04

  1. Remove block tooltip
  2. Upon hover show block/date as clickable
  3. Upon click open block explorer in the new tab

@dmtrjsg dmtrjsg added scope:proposals The "Proposals" page and related features community-dev issue suitable for community-dev pipeline and removed design Description of a feature scope or detailed requirements scope:council labels Feb 10, 2023
@chrlschwb chrlschwb mentioned this issue Mar 23, 2023
Merged
@thesan thesan added the qa-task label Oct 25, 2023
@chrlschwb
Copy link
Contributor

release:1.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community-dev issue suitable for community-dev pipeline enhancement New feature or request qa-task scope:proposals The "Proposals" page and related features SP:2
Projects
Pioneer Community Product Development
Status: Closed - On Prod
Milestone
No milestone
Development

No branches or pull requests
4 participants
@thesan @traumschule @dmtrjsg @chrlschwb