Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[USERSNAP] Past Elections: Shows incorrect blockheight for "Election Ended at" #3168

Closed
1 task
dmtrjsg opened this issue Jun 2, 2022 · 3 comments
Closed
1 task
Labels
bounty-backlog bug Something isn't working community-dev issue suitable for community-dev pipeline qa-task scope:council SP:2

Comments

@dmtrjsg
Copy link
Contributor

dmtrjsg commented Jun 2, 2022

Scope

  • Fix the page to show election ended blockheight, and not started (as right now).

Taken at: https://dao.joystream.org/#/election/past-elections
Fields:

  • Houston, we have a problem.: Past Elections: Shows incorrect blockheight for "Election Ended at"
  • Comment: SSIA
    The blockheights shown are for when the announcing period started rather than when an election ended.
  • Feedback: tomato#9464

SCREENSHOT
Download original image

Browser: Chrome 102 (Windows 10)
Screen size: 3440x1440
Browser size: 1320x1187
Open #269 in Usersnap

Powered by Usersnap.

@dmtrjsg dmtrjsg added the bug Something isn't working label Jun 2, 2022
@dmtrjsg dmtrjsg self-assigned this Jun 2, 2022
@dmtrjsg dmtrjsg added scope:council community-dev issue suitable for community-dev pipeline SP:2 bounty-backlog labels Jun 6, 2022
@dmtrjsg dmtrjsg removed their assignment Jun 8, 2022
@traumschule traumschule self-assigned this Nov 5, 2022
traumschule pushed a commit to traumschule/pioneer that referenced this issue Nov 5, 2022
- rebrand `ended at` to `started at` based on QN results
- fix re-appearance of Joystream#2656 ('round')
- election round tooltip with handbook link
@traumschule traumschule removed their assignment Nov 27, 2022
@polikosi
Copy link
Collaborator

tested on: https://dao-git-dev-joystream.vercel.app/#/settings?network-config=https://34.230.5.182.nip.io/network/config.json
✅works as expected

New council elected TX

Announcing period started TX

image
image

@traumschule
Copy link
Collaborator

Please test this with #3808 Carthage deployment and verify ended at block:
query { electionRounds { cycleId createdAt updatedAt endedAtTime endedAtBlock } }

    "electionRounds": [
      {
        "cycleId": 1,
        "createdAt": "2022-11-10T14:05:48.001Z",
        "updatedAt": "2022-11-25T15:28:00.001Z",
        "endedAtTime": "2022-11-25T15:28:00.001Z",
        "endedAtBlock": 216001
      },
      {
        "cycleId": 2,
        "createdAt": "2022-11-25T15:28:06.000Z",
        "updatedAt": "2022-11-25T15:28:06.000Z",
        "endedAtTime": null,
        "endedAtBlock": null
      }
    ]

carthage-elections

traumschule pushed a commit to traumschule/pioneer that referenced this issue Dec 9, 2022
@thesan
Copy link
Collaborator

thesan commented Dec 20, 2022

I tested it in production with 34.230.5.182.nip.io:

Screenshot from 2022-12-20 12-55-05

Screenshot from 2022-12-20 13-06-16

So I'm closing it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty-backlog bug Something isn't working community-dev issue suitable for community-dev pipeline qa-task scope:council SP:2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants