Past Election: Fix Blocktime link (#3168) #3808
Conversation
- rebrand `ended at` to `started at` based on QN results - fix re-appearance of Joystream#2656 ('round') - election round tooltip with handbook link
- by passing `noLink` from PastElectionsListRow via BlockTime to BlockInfo
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
traumschule
added
high-prio
community-dev
|
This also resurfaces network info. |
traumschule
changed the title
packages/ui/src/app/pages/Election/PastElections/PastElections.tsx
Outdated
Show resolved
Hide resolved
|
@traumschule is attempting to deploy a commit to the joystream Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
About the BlockInfo it's good to show "Block 1000" instead of "1000 Block". But since the network information is out of date (it should have been removed on the QN) I don't think there's a point having a tooltip here. This component should stick to the design. In addition lessInfo should be removed from the code. Finally maybe maybe the Link component could have a click handler with event.stopPropagation() but that's not very urgent (even now it's possible to right click "Open link in New Tab" to open the link.
About this PR the block height looks correct to me. So please rename PR, I'll close the issue.
packages/ui/src/council/components/election/pastElection/PastElectionStats.tsx
Outdated
Show resolved
Hide resolved
|
Thanks for the review! Will have a look. |
packages/ui/src/council/components/election/pastElection/PastElectionStats.tsx
Outdated
Show resolved
Hide resolved
traumschule
changed the title
traumschule
requested review from
oleksanderkorn,
chrlschwb,
freakstatic and
gyroflaw
|
Should we link to Calamar instead? |
Fixes #3168