Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👾 Sort proposal discussion by block (#3236) #3758

Merged
merged 2 commits into from
Dec 6, 2022
Merged

👾 Sort proposal discussion by block (#3236) #3758

merged 2 commits into from
Dec 6, 2022

Conversation

traumschule
Copy link
Collaborator

Fixes #3236

@vercel
Copy link

vercel bot commented Oct 25, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dao ✅ Ready (Inspect) Visit Preview Nov 18, 2022 at 3:51AM (UTC)
pioneer-2 ✅ Ready (Inspect) Visit Preview Nov 18, 2022 at 3:51AM (UTC)
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Nov 18, 2022 at 3:51AM (UTC)

@traumschule traumschule added community-dev issue suitable for community-dev pipeline builders-wg-code-review labels Oct 25, 2022
@oleksanderkorn
Copy link
Contributor

@traumschule lgtm, test is flaky so rerstarting the test should make it pass i hope, but i can't restart it, do not have permissions.

@WRadoslaw WRadoslaw added the waiting-for-checks PR is reviewed and approved, but is waiting for checks to complete label Nov 28, 2022
@WRadoslaw WRadoslaw changed the title Sort proposal discussion by block (#3236) 👾 Sort proposal discussion by block (#3236) Nov 28, 2022
@thesan thesan merged commit 8f63559 into Joystream:dev Dec 6, 2022
XxFlameCatxX pushed a commit to XxFlameCatxX/pioneer that referenced this pull request Dec 27, 2022
@traumschule @XxFlameCatxX
👾 Sort proposal discussion by block (Joystream#3236) (Joystream#3758)
d6eeac6 
* Sort proposal discussion by block (Joystream#3236)

* fixup

Co-authored-by: Joystream Stats <dev@joystreamstats.live>
XxFlameCatxX pushed a commit to XxFlameCatxX/pioneer that referenced this pull request Jan 14, 2023
@traumschule @XxFlameCatxX
👾 Sort proposal discussion by block (Joystream#3236) (Joystream#3758)
11ac57f 
* Sort proposal discussion by block (Joystream#3236)

* fixup

Co-authored-by: Joystream Stats <dev@joystreamstats.live>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksanderkorn oleksanderkorn oleksanderkorn approved these changes

@WRadoslaw WRadoslaw WRadoslaw approved these changes

@thesan thesan Awaiting requested review from thesan

Assignees
No one assigned
Labels
community-dev issue suitable for community-dev pipeline jsg-code-review waiting-for-checks PR is reviewed and approved, but is waiting for checks to complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect display of comments in a proposal
4 participants
@traumschule @oleksanderkorn @WRadoslaw @thesan