Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect display of comments in a proposal #3236

Closed
1 task
adovrodion opened this issue Jun 14, 2022 · 5 comments · Fixed by #3758
Closed
1 task

Incorrect display of comments in a proposal #3236

adovrodion opened this issue Jun 14, 2022 · 5 comments · Fixed by #3758
Labels
bounty-backlog bug Something isn't working community-dev issue suitable for community-dev pipeline qa-task qa-tested-ready-for-prod release:mainnet scope:proposals The "Proposals" page and related features SP:2

Comments

@adovrodion
Copy link

adovrodion commented Jun 14, 2022 •
edited by dmtrjsg
Loading

Scope

  • Use block count for sorting

⚠️ if this fails then the issue is with Hydra - post the results of attempt to comments

During the discussion it was possible to find out that the proposal does not correctly display more than 15 comments - https://dao.joystream.org/#/proposals/preview/274

The 16th comment moved up the discussion. You can see from the time in the screenshot that it is located incorrectly
image
@adovrodion adovrodion added the bug Something isn't working label Jun 14, 2022
@dmtrjsg dmtrjsg added to-triage scope:forum The "Forum" page and related features scope:proposals The "Proposals" page and related features community-dev issue suitable for community-dev pipeline SP:2 and removed to-triage scope:forum The "Forum" page and related features labels Jun 17, 2022
traumschule pushed a commit to traumschule/pioneer that referenced this issue Oct 25, 2022
Display whitelisted members for closed proposal discussions (Joystrea…
567f0ab 
…m#3236)
traumschule pushed a commit to traumschule/pioneer that referenced this issue Oct 25, 2022
Sort proposal discussion by block (Joystream#3236)
1425596
@traumschule traumschule mentioned this issue Oct 25, 2022
Merged
@traumschule traumschule mentioned this issue Nov 28, 2022
Closed
thesan pushed a commit that referenced this issue Dec 6, 2022
@traumschule
👾 Sort proposal discussion by block (#3236) (#3758)
8f63559 
* Sort proposal discussion by block (#3236)

* fixup

Co-authored-by: Joystream Stats <dev@joystreamstats.live>
@thesan thesan reopened this Dec 6, 2022
@ivanturlakov
Copy link

ivanturlakov commented Dec 8, 2022 •
edited
Loading

Tested on https://pioneer-2-git-mainnet-joystream.vercel.app/#/proposals/preview/41
wss://34.230.5.182.nip.io/ws-rpc

Got an error while adding 2nd comment (after transaction execution)
This error also appears when opening a proposal page
Снимок экрана 2022-12-08 в 12 32 25

@traumschule traumschule self-assigned this Dec 8, 2022
traumschule pushed a commit to traumschule/pioneer that referenced this issue Dec 8, 2022
Initialize discussionPosts before thread is loaded (Joystream#3236)
302aa2d
@traumschule traumschule mentioned this issue Dec 8, 2022
Closed
@thesan thesan mentioned this issue Dec 9, 2022
Merged
@thesan
Copy link
Collaborator

thesan commented Dec 9, 2022

@ivanturlakov this should be fixed by #3965

@ivanturlakov
Copy link

✅ Tested on https://pioneer-2-git-mainnet-joystream.vercel.app/#/proposals/preview/47
wss://34.230.5.182.nip.io/ws-rpc

For sorting used a blocks counter
⚠️ The latest comments are on top of the list

Снимок экрана 2022-12-10 в 12 59 22

@ivanturlakov ivanturlakov mentioned this issue Dec 10, 2022
Closed
@traumschule traumschule removed their assignment Dec 10, 2022
@traumschule
Copy link
Collaborator

The latest comments are on top of the list

Do you think that should be changed?

traumschule pushed a commit to traumschule/pioneer that referenced this issue Dec 11, 2022
Reverse order of proposal discussion posts (Joystream#3236)
2743e59
@traumschule traumschule mentioned this issue Dec 11, 2022
Open
@ivanturlakov
Copy link

Do you think that should be changed?

No, just noticed that the display chronology was changed. I think this is a subjective thing and the community will let us know if anything needs to be changed 👍

@thesan thesan closed this as completed Dec 16, 2022
XxFlameCatxX pushed a commit to XxFlameCatxX/pioneer that referenced this issue Dec 27, 2022
@traumschule @XxFlameCatxX
👾 Sort proposal discussion by block (Joystream#3236) (Joystream#3758)
d6eeac6 
* Sort proposal discussion by block (Joystream#3236)

* fixup

Co-authored-by: Joystream Stats <dev@joystreamstats.live>
@traumschule traumschule mentioned this issue Jan 4, 2023
Closed
XxFlameCatxX pushed a commit to XxFlameCatxX/pioneer that referenced this issue Jan 14, 2023
@traumschule @XxFlameCatxX
👾 Sort proposal discussion by block (Joystream#3236) (Joystream#3758)
11ac57f 
* Sort proposal discussion by block (Joystream#3236)

* fixup

Co-authored-by: Joystream Stats <dev@joystreamstats.live>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bounty-backlog bug Something isn't working community-dev issue suitable for community-dev pipeline qa-task qa-tested-ready-for-prod release:mainnet scope:proposals The "Proposals" page and related features SP:2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

👾 Sort proposal discussion by block (#3236) traumschule/pioneer
5 participants
@thesan @traumschule @ivanturlakov @adovrodion @dmtrjsg