Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal discussion fixes #3969

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

Proposal discussion fixes #3969

wants to merge 11 commits into from

Conversation

traumschule
Copy link
Contributor

@traumschule traumschule commented Dec 11, 2022 •
edited
Loading

@vercel
Copy link

vercel bot commented Dec 11, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2023 7:44pm
pioneer-2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2023 7:44pm
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2023 7:44pm

@traumschule traumschule added community-dev issue suitable for community-dev pipeline builders-wg-code-review labels Dec 12, 2022
@traumschule
Copy link
Contributor Author

Fixed a typo and changed 'unmoderated' to 'open': 4f84c6f

oleksanderkorn
oleksanderkorn approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@oleksanderkorn oleksanderkorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traumschule
Copy link
Contributor Author

re: revert 2743e59?

@thesan thesan changed the base branch from dev to main December 20, 2022 09:45
@thesan thesan changed the base branch from main to dev December 20, 2022 09:45
This was referenced Jan 4, 2023
Merged
Closed
thesan
thesan requested changes Feb 13, 2023
View reviewed changes
Copy link
Member

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@traumschule please avoid grouping multiple issues in one PR. Smaller PR go through shorter review/changes cycles

packages/ui/src/proposals/components/ProposalHistory.tsx Outdated Show resolved Hide resolved
packages/ui/src/app/pages/Proposals/ProposalPreview.tsx Outdated Show resolved Hide resolved
packages/ui/src/app/pages/Proposals/ProposalPreview.tsx Show resolved Hide resolved
@traumschule @thesan
spacing
6ef31ac 
Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>
@chrlschwb chrlschwb closed this Mar 22, 2023
@traumschule traumschule reopened this Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksanderkorn oleksanderkorn oleksanderkorn approved these changes

@freakstatic freakstatic Awaiting requested review from freakstatic

@dmtrjsg dmtrjsg Awaiting requested review from dmtrjsg

@thesan thesan Awaiting requested review from thesan

@chrlschwb chrlschwb Awaiting requested review from chrlschwb

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
community-dev issue suitable for community-dev pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@traumschule @thesan @oleksanderkorn @chrlschwb