Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

font size control #4094 #4264

Closed
wants to merge 2 commits into from
Closed

font size control #4094 #4264

wants to merge 2 commits into from

Conversation

chrlschwb
Copy link
Contributor

@chrlschwb chrlschwb commented Mar 24, 2023 •
edited
Loading

Font text too small? #4094

@vercel
Copy link

vercel bot commented Mar 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dao ✅ Ready (Inspect) Visit Preview Mar 28, 2023 at 2:46AM (UTC)
pioneer-2 ✅ Ready (Inspect) Visit Preview Mar 28, 2023 at 2:46AM (UTC)
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Mar 28, 2023 at 2:46AM (UTC)

@chrlschwb chrlschwb removed the request for review from traumschule March 26, 2023 17:10
traumschule
traumschule reviewed Mar 26, 2023
View reviewed changes
packages/ui/src/common/components/MarkdownPreview/MarkdownPreviewStyles.tsx
default:
return '16px'
return '20px'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a bit much? Also text in tables is different now.

fontsize

Probably hard to find one setting that fits all. Other pages use a dropdown to change the font size depending on user needs. Or something PDF viewers have:
size

Copy link
Contributor Author

@chrlschwb chrlschwb Mar 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have fixed the table font size.

Let's merge this one and create a new issue for font size selection dropdown.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I assume it's still too big for some users. Also we are wasting space left and right, especially a problem on mobile (=> followup).

font

traumschule
traumschule approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@traumschule traumschule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better already.

packages/ui/src/common/components/MarkdownPreview/MarkdownPreviewStyles.tsx
default:
return '16px'
return '20px'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I assume it's still too big for some users. Also we are wasting space left and right, especially a problem on mobile (=> followup).

font

@thesan
Copy link
Member

thesan commented Mar 30, 2023

@chrlschwb I added a #4094 (comment) on the issue. Feel free to respond there.

@chrlschwb chrlschwb mentioned this pull request Mar 30, 2023
Closed
@traumschule traumschule added the community-dev issue suitable for community-dev pipeline label Mar 30, 2023
@chrlschwb chrlschwb closed this Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traumschule traumschule traumschule approved these changes

@thesan thesan Awaiting requested review from thesan

Assignees
No one assigned
Labels
community-dev issue suitable for community-dev pipeline jsg-code-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrlschwb @thesan @traumschule