-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font text too small? #4094
Comments
A smart way UI to increase font size would be great (without having to resort to page zoom). Also the font isn't a most readable one. |
When writing forum posts I started to increase font size to |
Yeah, the fact that you were doing that is a pretty solid sign we should increase this 🤣 |
@bedeho @dmtrjsg @traumschule sorry I'm late on this but I'm not convinced increasing the font size is the right move. It doesn't has to do with age as much as screen dpi getting denser with time, now there are even 4k laptop screens 😮 . However most websites don't increase there font sizes in reaction, e.g github, reddit, twitter all keep their text smaller than 16px (which is Pioneer's current default font size). Instead Chrome matches the user's systems font scaling factor. I mainly use FF (mostly at 110% zoom but that's easy to adapt depending on the page) but when I open e.g: https://dao-git-fork-chrlschwb-fix-4094-fonttextsmall-joystream.vercel.app/#/forum/thread/324 on Chrome due to my system 120% font scaling factor I get WDYT ? |
I think we should just add a font size controller. zoom in and zoom out... |
@chrlschwb If that's available in both system and browser settings, why would we bloat the scope of Pioneer to replicate exactly same feature? I think based on that and benchmarking with popular websites we should close 4308.. |
@traumschule the font color might be more of an issue than the font itself. In contrast with the GH font color of this message (if you are using the "light default" theme): And it's not even the accessibility high contrast theme. |
Good point. Not sure if that's too hacky but we could use
|
Yes you may very well be right that sizing is not the right fix, make the call.
I don't think this is wise. Products should just work and have good readability, adding tons of controls that users have to understand and manage should be the last resort, and not really warranted here. |
I will just try to change the font color then. |
✅ Tested on https://dao-git-dev-joystream.vercel.app/#/forum/thread/2 |
Perhaps I'm just getting old, but isn't the font text just needlessly small, despite being the main thing you want to process? Compare this
to this
isn't the latter way way easier to read, but also looks fine?
The text was updated successfully, but these errors were encountered: