Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Font color for visibility (#4094) #4342

Merged
merged 6 commits into from
Apr 24, 2023
Merged

Change Font color for visibility (#4094) #4342

merged 6 commits into from
Apr 24, 2023

Conversation

chrlschwb
Copy link
Contributor

fixes issue #4094

@vercel
Copy link

vercel bot commented Apr 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview Apr 21, 2023 4:37pm
pioneer-2 ✅ Ready (Inspect) Visit Preview Apr 21, 2023 4:37pm
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Apr 21, 2023 4:37pm

@chrlschwb chrlschwb requested review from traumschule and removed request for oleksanderkorn April 11, 2023 02:16
traumschule
traumschule suggested changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@traumschule traumschule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except

packages/markdown-editor/src/MarkdownEditor.js Outdated Show resolved Hide resolved
thesan
thesan reviewed Apr 14, 2023
View reviewed changes
Copy link
Member

@thesan thesan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrlschwb LGTM!

Just please accept @oleksanderkorn suggestion see comment 👇

@thesan thesan added community-dev issue suitable for community-dev pipeline and removed jsg-code-review labels Apr 14, 2023
chrlschwb
chrlschwb commented Apr 21, 2023
View reviewed changes
Copy link
Contributor Author

@chrlschwb chrlschwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete empty line

@chrlschwb chrlschwb requested a review from thesan April 21, 2023 14:50
@thesan thesan added the waiting-for-checks PR is reviewed and approved, but is waiting for checks to complete label Apr 21, 2023
@thesan thesan removed the waiting-for-checks PR is reviewed and approved, but is waiting for checks to complete label Apr 24, 2023
@thesan thesan merged commit f5c124c into Joystream:dev Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksanderkorn oleksanderkorn oleksanderkorn approved these changes

@thesan thesan thesan approved these changes

@traumschule traumschule Awaiting requested review from traumschule

Assignees
No one assigned
Labels
community-dev issue suitable for community-dev pipeline jsg-code-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrlschwb @thesan @oleksanderkorn @traumschule