Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce a non-exported filltype #26

Merged
merged 1 commit into from
Apr 2, 2020
Merged

introduce a non-exported filltype #26

merged 1 commit into from
Apr 2, 2020

Conversation

johnnychen94
Copy link
Member

@johnnychen94 johnnychen94 commented Mar 20, 2020

This continues #24 by make filltype conversion extensible to other
packages, e.g., it makes lifting filltype for Colorants possible
in other packages.

This is a rework of #25 by breaking it into two PRs

johnnychen94 added a commit to JuliaImages/ImageCore.jl that referenced this pull request Mar 20, 2020
This ensure that `fillvalue` is of dominant role of eltype of PaddedView.

One consequence of this is transparent color is correctly filled even if
`img` isn't of eltype `ARGB`:

`PaddedView(ARGB(0, 0, 0, 0), img, indices)`

This is a rework of JuliaArrays/PaddedViews.jl#25
and co-operates JuliaArrays/PaddedViews.jl#26
This continues #24 by make filltype conversion extensible to other
packages, e.g., it makes lifting filltype for `Colorants` possible
in other packages.

This is a rework/breaking PR of #25
@johnnychen94
Copy link
Member Author

I believe this is a safe refactor so I'm merging this now

The failed test on macOS is unrelated.

@johnnychen94 johnnychen94 merged commit fab0346 into master Apr 2, 2020
@johnnychen94 johnnychen94 deleted the jc/filltype branch April 2, 2020 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant