add PaddedViews.filltype specifications on Colorants #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exports two new names: PaddedView and sym_paddedviews
This ensure that `fillvalue` is of dominant role of eltype of PaddedView. One consequence of this is transparent color is correctly filled even if `img` isn't of eltype `ARGB`: `PaddedView(ARGB(0, 0, 0, 0), img, indices)` This is a rework of JuliaArrays/PaddedViews.jl#25 and co-operates JuliaArrays/PaddedViews.jl#26
johnnychen94
changed the title
|
These two PRs (this and #127) for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that
fillvalue::Colorantis of the dominant role of eltype of PaddedView.One consequence of this is transparent color is correctly filled even if
imgisn't of eltypeARGB:This PR also reexports PaddedViews to introduce
PaddedViewandsym_paddedviews(JuliaArrays/PaddedViews.jl#23)Ref: This is a rework of JuliaArrays/PaddedViews.jl#25 and co-operates JuliaArrays/PaddedViews.jl#26