Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read!(io::IO, ::Type{SA}) #505

Closed
tpapp opened this issue Sep 23, 2018 · 2 comments
Closed

read!(io::IO, ::Type{SA}) #505

tpapp opened this issue Sep 23, 2018 · 2 comments

Comments

@tpapp
Copy link
Contributor

tpapp commented Sep 23, 2018

Why is this a method of read!, instead of read? It does not modify any of its arguments.
@andyferris
Copy link
Member

Good point. We should have a read! method for MArray, SizedArray, etc - but yes, read for immutable arrays.

jw3126 added a commit to jw3126/StaticArrays.jl that referenced this issue Oct 2, 2018
@jw3126
distinguish read and read\! (JuliaArrays#505)
3fd3c55
@jw3126 jw3126 mentioned this issue Oct 2, 2018
Closed
@c42f
Copy link
Member

c42f commented Oct 9, 2018

Yes the read() API makes perfect sense for StaticArrays ­— removing read was a small part of #451 which should be rolled back.

@c42f c42f mentioned this issue Oct 9, 2018
Merged
@c42f c42f closed this as completed in #515 Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

distinguish read and read\! (#505) jw3126/StaticArrays.jl
3 participants
@tpapp @c42f @andyferris