Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distinguish read and read\! (#505) #510

Closed
wants to merge 1 commit into from
Closed

Conversation

jw3126
Copy link
Contributor

@jw3126 jw3126 commented Oct 2, 2018

fix #505

@c42f
Copy link
Member

c42f commented Oct 9, 2018

I started reviewing this but thought we can be much more minimal in fixing this. My preferred style for the fix here: #515

To explain #515

  • it leaves read! alone so that it remains non-allocating (I think what you've got here would be allocating, though I could be wrong with the latest compiler)
  • leaves the tests alone, because IMO the very explicit style is easier to debug when there's a test failure.

Bit frustrating that this previously working feature was removed back in the rush to 0.7 and will be good to have it fixed either way!

@jw3126
Copy link
Contributor Author

jw3126 commented Oct 9, 2018

I think you are right, lets close this.

@jw3126 jw3126 closed this Oct 9, 2018
@c42f
Copy link
Member

c42f commented Oct 9, 2018

read!(io, myarray) does not mutate myarray::MArray

Yikes, I hope not... checking... seems ok to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read!(io::IO, ::Type{SA})
2 participants