Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lu seems to be ambiguous on Julia Nightly #920

Closed
kellertuer opened this issue Jun 8, 2021 · 2 comments · Fixed by #921 or #932
Closed

lu seems to be ambiguous on Julia Nightly #920

kellertuer opened this issue Jun 8, 2021 · 2 comments · Fixed by #921 or #932

Comments

@kellertuer
Copy link

kellertuer commented Jun 8, 2021

Sometimes I check our Nightly, when they error and I noticed here that the current lu decomposition for 5x5 (but not for 4x4, 3x3 or 2x2) seems to be ambiguous currently?

  MethodError: lu(::SizedMatrix{5, 5, Float64, 2, Matrix{Float64}}, ::Val{true}) is ambiguous. Candidates:
948
    lu(A::AbstractMatrix, ::Val{true}; check) in LinearAlgebra at deprecated.jl:70
949
    lu(A::StaticMatrix{N, N}, pivot::Union{Val{false}, Val{true}}; check) where N in StaticArrays at StaticArrays/uH2MB/src/lu.jl:40
950
    lu(A::StaticMatrix, pivot::Union{Val{false}, Val{true}}; check) in StaticArrays at StaticArrays/uH2MB/src/lu.jl:33
951
  Possible fix, define
952
    lu(::StaticMatrix{N, N}, ::Val{true}) where N

This seems to come originally from our matrix exponential call here.

@fgasdia
Copy link

fgasdia commented Jun 10, 2021

Just to add - I see an ambiguous lu for a 4x4 on Nightly for a package of mine: here

  Expression: [W[1] W[3]; W[2] W[4]] ≈ 2 * (L \ T) * L
  MethodError: lu(::SMatrix{4, 4, ComplexF64, 16}, ::Val{true}) is ambiguous. Candidates:
    lu(A::AbstractMatrix, ::Val{true}; check) in LinearAlgebra at deprecated.jl:70
    lu(A::StaticMatrix{N, N}, pivot::Union{Val{false}, Val{true}}; check) where N in StaticArrays at /home/runner/.julia/packages/StaticArrays/uH2MB/src/lu.jl:40
    lu(A::StaticMatrix, pivot::Union{Val{false}, Val{true}}; check) in StaticArrays at /home/runner/.julia/packages/StaticArrays/uH2MB/src/lu.jl:33
  Possible fix, define
    lu(::StaticMatrix{N, N}, ::Val{true}) where N

mateuszbaran added a commit that referenced this issue Jun 10, 2021
@mateuszbaran mateuszbaran mentioned this issue Jun 10, 2021
@mateuszbaran
Copy link
Collaborator

#921 should fix this.

@mateuszbaran mateuszbaran linked a pull request Jun 10, 2021 that will close this issue
mateuszbaran added a commit that referenced this issue Jun 20, 2021
* Fix #920

* if needs to be static

* bump version
thchr added a commit to thchr/StaticArrays.jl that referenced this issue Jul 1, 2021
thchr added a commit to thchr/StaticArrays.jl that referenced this issue Jul 1, 2021
mateuszbaran pushed a commit that referenced this issue Jul 2, 2021
…u` (#932)

* fix `qr` method ambiguities (#931) and lingering `lu` ambiguities (#920)

* fix inferrence issues due to using `@invoke` for `lu` keyword arguments

* bump version
thchr pushed a commit to thchr/StaticArrays.jl that referenced this issue Jul 8, 2021
* Fix JuliaArrays#920

* if needs to be static

* bump version
thchr added a commit to thchr/StaticArrays.jl that referenced this issue Jul 8, 2021
…ties for `lu` (JuliaArrays#932)

* fix `qr` method ambiguities (JuliaArrays#931) and lingering `lu` ambiguities (JuliaArrays#920)

* fix inferrence issues due to using `@invoke` for `lu` keyword arguments

* bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants