Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakage in 1.7+ with QR factorization #931

Closed
gbaraldi opened this issue Jul 1, 2021 · 3 comments
Closed

Breakage in 1.7+ with QR factorization #931

gbaraldi opened this issue Jul 1, 2021 · 3 comments
Labels

Comments

@gbaraldi
Copy link

gbaraldi commented Jul 1, 2021

Calling qr on a simple SMatrix is now giving ambiguous method error on versions after 1.6.1
1.6.1

using LinearAlgebra, StaticArrays; qr(SA[1 2; 3 4])

StaticArrays.QR{SMatrix{2, 2, Float64, 4}, SMatrix{2, 2, Float64, 4}, SVector{2, Int64}}([-0.316227766016838 -0.9486832980505138; -0.9486832980505138 0.316227766016838], [-3.1622776601683795 -4.427188724235731; 0.0 -0.6324555320336751], [1, 2])

On 1.7-beta2

julia> using LinearAlgebra, StaticArrays; qr(SA[1 2; 3 4])
ERROR: MethodError: qr(::SMatrix{2, 2, Int64, 4}, ::Val{false}) is ambiguous. Candidates:

qr(A::AbstractMatrix, ::Val{false}; kwargs...) in LinearAlgebra at deprecated.jl:70
  qr(A::StaticMatrix, pivot::Union{Val{false}, Val{true}}) in StaticArrays at /Users/gabrielbaraldi/.julia/packages/StaticArrays/aMe0r/src/qr.jl:37
Possible fix, define
  qr(::StaticMatrix, ::Val{false})
Stacktrace:
 [1] qr(A::SMatrix{2, 2, Int64, 4})
   @ StaticArrays ~/.julia/packages/StaticArrays/aMe0r/src/qr.jl:38
 [2] top-level scope
   @ REPL[3]:1

On 1.8

julia> using LinearAlgebra, StaticArrays; qr(SA[1 2; 3 4])
ERROR: MethodError: qr(::SMatrix{2, 2, Int64, 4}, ::Val{false}) is ambiguous. Candidates:
  qr(A::AbstractMatrix, ::Val{false}; kwargs...) in LinearAlgebra at deprecated.jl:70
  qr(A::StaticMatrix, pivot::Union{Val{false}, Val{true}}) in StaticArrays at /Users/gabrielbaraldi/.julia/packages/StaticArrays/aMe0r/src/qr.jl:37
Possible fix, define
  qr(::StaticMatrix, ::Val{false})

This looks like a julia issue, but I'm not sure, since it affects at least StaticArrays I am opening an issue here and an issue upstream.

@gbaraldi
Copy link
Author

gbaraldi commented Jul 1, 2021

It seems to have been introduced by JuliaLang/julia#40623

@gbaraldi gbaraldi changed the title Possible regression in 1.7+ with QR factorization Breakage in 1.7+ with QR factorization Jul 1, 2021
@mateuszbaran
Copy link
Collaborator

This looks similar to #920 and very likely requires a similar fix.

thchr added a commit to thchr/StaticArrays.jl that referenced this issue Jul 1, 2021
thchr added a commit to thchr/StaticArrays.jl that referenced this issue Jul 1, 2021
mateuszbaran pushed a commit that referenced this issue Jul 2, 2021
…u` (#932)

* fix `qr` method ambiguities (#931) and lingering `lu` ambiguities (#920)

* fix inferrence issues due to using `@invoke` for `lu` keyword arguments

* bump version
@mateuszbaran
Copy link
Collaborator

This is now fixed by #932

thchr added a commit to thchr/StaticArrays.jl that referenced this issue Jul 8, 2021
…ties for `lu` (JuliaArrays#932)

* fix `qr` method ambiguities (JuliaArrays#931) and lingering `lu` ambiguities (JuliaArrays#920)

* fix inferrence issues due to using `@invoke` for `lu` keyword arguments

* bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants