This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
Changes to support color VT sequences on windows #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code already had special handling for decoding utf-8 characters correctly for the UCS-2 conhost (trailing incomplete bytes and characters > 0xFFFF). Rather than trying to duplicate that, we can simply delete the duplicate code-path and selectively disable the parts that do not apply.
This reverts commit 587ebd3.
|
probably @vtjnash is the right person to review this |
|
This repository is now archived, please consider reopening this at https://github.com/JuliaLang/libuv Note that this only fixes one of the two regressions caused by this code path. Until a fix for JuliaLang/julia#26894 is also available, we can't merge this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.