Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell mode on windows sometimes corrupt the terminal state #26894

Closed
KristofferC opened this issue Apr 24, 2018 · 7 comments
Closed

shell mode on windows sometimes corrupt the terminal state #26894

KristofferC opened this issue Apr 24, 2018 · 7 comments
Labels
bug Indicates an unexpected problem or unintended behavior regression Regression in behavior compared to a previous version REPL Julia's REPL (Read Eval Print Loop) system:windows Affects only Windows

Comments

@KristofferC
Copy link
Member

repo ;ls in windows REPL.

image

Seems to work on 0.6.2. Can anyone repro?

@KristofferC KristofferC added bug Indicates an unexpected problem or unintended behavior system:windows Affects only Windows REPL Julia's REPL (Read Eval Print Loop) regression Regression in behavior compared to a previous version labels Apr 24, 2018
@helgee
Copy link
Contributor

helgee commented Apr 24, 2018

Successfully reproduced, is this the ls from Git?

@helgee
Copy link
Contributor

helgee commented Apr 24, 2018

Seems to happen with all the utils shipped with Git for Windows:

               _
   _       _ _(_)_     |  A fresh approach to technical computing
  (_)     | (_) (_)    |  Documentation: https://docs.julialang.org
   _ _   _| |_  __ _   |  Type "?help" for help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 0.7.0-DEV.4939 (2018-04-24 02:56 UTC)
 _/ |\__'_|_|_|\__'_|  |  Commit ef9168a6f8* (0 days old master)
|__/                   |  i686-w64-mingw32

shell> ..\\Programs\\Git\\usr\\bin\\echo.exe blob
blob

�[7C�[32m�[1mjulia> �[0m�[0m

@KristofferC
Copy link
Member Author

Perhaps we should add a

write(terminal, "\033c") (reset the terminal state)

in the beginning of

function write_prompt(terminal, p::Prompt)
prefix = prompt_string(p.prompt_prefix)
suffix = prompt_string(p.prompt_suffix)
write(terminal, prefix)
write(terminal, Base.text_colors[:bold])
width = write_prompt(terminal, p.prompt)

@PetrKryslUCSD
Copy link

@KristofferC : This issue has been closed, but has the problem been solved? I can still see it happening with Version 0.7.0-beta2.43...

@KristofferC
Copy link
Member Author

How is this closed?

@PetrKryslUCSD
Copy link

Sorry, I meant #27782.

@KristofferC
Copy link
Member Author

That is a dup of this issue.

vtjnash added a commit to JuliaAttic/libuv-archive that referenced this issue Jul 27, 2018
vtjnash added a commit that referenced this issue Jul 27, 2018
fixes #27267
fixes #26894

We are not using this code now, so it is not important to keep active
for us right now. In the future, we should look into fixing these
bugs locally and filing an upstream bug report for it.
vtjnash added a commit to vtjnash/libuv that referenced this issue Nov 14, 2018
vtjnash added a commit to vtjnash/libuv that referenced this issue Nov 14, 2018
vtjnash added a commit to vtjnash/libuv that referenced this issue Nov 14, 2018
KristofferC pushed a commit that referenced this issue Feb 11, 2019
fixes #27267
fixes #26894

We are not using this code now, so it is not important to keep active
for us right now. In the future, we should look into fixing these
bugs locally and filing an upstream bug report for it.
vtjnash added a commit to vtjnash/libuv that referenced this issue May 28, 2019
vtjnash added a commit to JuliaLang/libuv that referenced this issue Jun 10, 2019
musm pushed a commit to musm/libuv that referenced this issue Jul 8, 2020
musm pushed a commit to musm/libuv that referenced this issue Jul 8, 2020
musm pushed a commit to musm/libuv that referenced this issue Jul 8, 2020
Reverts PR libuv#1143
Refs: JuliaLang/julia#27267
Refs: JuliaLang/julia#26894

(cherry picked from commit 587ebd3)
(cherry picked from commit 4736c31)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior regression Regression in behavior compared to a previous version REPL Julia's REPL (Read Eval Print Loop) system:windows Affects only Windows
Projects
None yet
Development

No branches or pull requests

3 participants