make permutedims more flexible #3004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnj
reviewed
Feb 16, 2022
nalimilan
reviewed
Feb 16, 2022
| contained in the `src_namescol` are not all `Symbol` or all `AbstractString`, | ||
| or can all be converted to `AbstractString` using `convert`. If `false` | ||
| then any values are accepted and the will be changed to strings using | ||
| the `string` function. |
There was a problem hiding this comment.
Suggested change
| the `string` function. | |
| the [`string`](@ref) function. |
There was a problem hiding this comment.
@nalimilan would such reference to Base Julia work?
CC @mortenpi
There was a problem hiding this comment.
(I have accidentally committed this suggestion, but the question remains)
Thank you!
There was a problem hiding this comment.
OK - no need to answer - CI gave me the answer. I revert the change.
There was a problem hiding this comment.
Ah yes sorry that doesn't work indeed. So my net contribution to this PR is clearly negative...
There was a problem hiding this comment.
your 1 PR approval is worth 1000 LOC of contribution 😄
bkamins
commented
Feb 17, 2022
bkamins
commented
Feb 17, 2022
bkamins
commented
Feb 17, 2022
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
bkamins
commented
Feb 17, 2022
nalimilan
approved these changes
Feb 17, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3003.
This is good for review.