WIP: DataTables.jl Backport #1214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shorter written that way for now. Filed as JuliaStats/NullableArrays.jl#144.
This depends on a CategoricalArrays change by which levels are sorted when creating the array.
There's no inconsistency here: when the input is a Matrix, there's no point in returning a NullableArray. Anyway, these are test methods.
We don't have to handle this right now.
Keep this in DataFrames for now, renaming it to the more explicit sharepools(). Also relax signatures to accept non-Nullable categorical arrays.
These were not exercized by the tests, and the use case for them isn't obvious. (They were formerly methods of DataArrays.PooledDataArray().)
For NullableArrays, even current git master is not enough at this time.
Tests pass, but the Nullable{Any} results could be annoying for users.
New type merging NominalArray and OrdinalArray in 0.0.5.
These shouldn't live in DataFrames.
The full code isn't that longer, and we can go back to the original code when RDataset will have been ported.
Since we give them the same semantics for now, there's no point in keeping separate functions.
More logical name for the constructor provided by CategoricalArray. categorical!() is the in-place equivalent provided only by DataFrames. Also move the compacting logic into CategoricalArrays, as it's both a cleaner design and a more efficient one.
io.md does not exist since the readtable() has been removed. Pooling should be called categorical, so rename the file and sections.
CategoricalValue entries should always be printed via showcompact() in order to get a short representation. This uses ourshowcompact() to do that when printing DataTables to REPL via show, as well as when printing them to HTML, LaTeX and CSV via printtable(). Also fix a failure due to duplicated keyword arguments on Julia 0.7.
- Changed julia requirement to 0.6 minimum - Stopped testing on 0.5 - Removed Compat dependency - Fixed a few 0.6 warnings.
quinnj
force-pushed
the
rf/datatables
branch
from
22040fd to
55ecb4c
Compare
|
Rebased. Porting over #66 now. |
|
@quinnj Also push the commits to nl/datatables3 when they are ready, that will be the branch to use in the end. |
|
Ok, got a good start here. Merged #66 with this branch and resolved all the conflicts/renaming issues (there are still a few |
quinnj
force-pushed
the
rf/datatables
branch
from
1f254a5 to
1e866e0
Compare
|
I've included the new changes into nl/datatables4, and merged it with a merge commit into a new nl/datatables-backport branch which was equivalent to master: #1220. If that's OK, I can do the same directly on master (or rename master to release-0.9 and nl/datatables-backport to master). |
|
I'll note that I was planning on rebasing (vs merging) the changes from DataTables#66 into this branch. The rf/datatables and nl/datatables-backport branches are very different now, so I'm just going to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nl/datatables2 branch rebased with master.
TODO:
NOTES:
Vector{?T}now that Nulls.jl is registered.