Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WeakRefStringArray: make eltype respect Missing #20

Closed
wants to merge 6 commits into from

Conversation

alyst
Copy link
Contributor

@alyst alyst commented Dec 20, 2017

Enhances #17 so that WeakRefStringArray allows missing iff
the underlying WeakRefString Array allows missing.

Should fix the eltypes of the dataframes returned by CSV.jl.

Needs tests.

@codecov
Copy link

codecov bot commented Dec 20, 2017

Codecov Report

Merging #20 into master will decrease coverage by 0.46%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage   78.72%   78.26%   -0.47%     
==========================================
  Files           1        1              
  Lines          47       46       -1     
==========================================
- Hits           37       36       -1     
  Misses         10       10
Impacted Files Coverage Δ
src/WeakRefStrings.jl 78.26% <100%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69d5ff8...57aff55. Read the comment docs.

enhances JuliaData#17 so that WeakRefStringArray allows missing iff
the underlying WeakRefString Array allows missing
should fix CI on v0.7
@alyst
Copy link
Contributor Author

alyst commented Dec 20, 2017

I've tried to fix 0.7 adding ncodeunits(), but there's another error when calling WeakRefStringArray(data::Vector{UInt8}, A::Array{Union{WeakRefString{UInt8}, Missing}, N}) ctor, which I don't understand.
Looks like the ctor doesn't recognize it should support Missing.
This doesn't happen on 0.6 and I don't have a working 0.7 setup.

@quinnj
Copy link
Member

quinnj commented Dec 24, 2017

Closing in favor of #21 (hope you don't mind that I stole several bits from here though 😃 )

@quinnj quinnj closed this Dec 24, 2017
@alyst
Copy link
Contributor Author

alyst commented Dec 24, 2017

@quinnj Sure, no problem

@nalimilan
Copy link
Member

As noted on #21, I think we still need this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants