-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WeakRefStringArray: make eltype respect Missing #20
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
- Coverage 78.72% 78.26% -0.47%
==========================================
Files 1 1
Lines 47 46 -1
==========================================
- Hits 37 36 -1
Misses 10 10
Continue to review full report at Codecov.
|
checks dimensionality
enhances JuliaData#17 so that WeakRefStringArray allows missing iff the underlying WeakRefString Array allows missing
should fix CI on v0.7
I've tried to fix 0.7 adding |
Closing in favor of #21 (hope you don't mind that I stole several bits from here though 😃 ) |
@quinnj Sure, no problem |
As noted on #21, I think we still need this. |
Enhances #17 so that WeakRefStringArray allows missing iff
the underlying WeakRefString Array allows missing.
Should fix the eltypes of the dataframes returned by CSV.jl.
Needs tests.