Fix the bug where prefix buffers too much
#210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change to not overbuffer. This bug fix brake the test `windows_newlines` but I think the test is incorrect.
Paalon
changed the title
src/buffered_input.jl part 3src/buffered_input.jl part 3
Paalon
changed the title
src/buffered_input.jl part 3src/buffered_input.jl part 3
|
As mentioned in #211, the test is wrong and this PR is a bug fix. |
Paalon
changed the title
src/buffered_input.jl part 3prefix buffers too much
GunnarFarneback
approved these changes
Jun 22, 2024
kescobo
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #208. Bug fix of
prefix(::BufferedInput, ::Integer). Change to not overbuffer. This bug fix break the testwindows_newlinesbut I think the test is incorrect. Related to #188 and #207. Other tests are all OK.