[Bug Fix] Fix malformed test for Windows. #211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Performance improvement of `scan_line_break`. * Rename `scan_line_break` to `yaml_1_1_scan_line_break`. * Add `yaml_1_2_scan_line_break`. * Add better comments. * Add a TODO comment about possible bugs.
Change to not overbuffer. This bug fix brake the test `windows_newlines` but I think the test is incorrect.
This was referenced Jun 17, 2024
|
I split this PR to multiple ones. |
|
All the contents of this PR are divided into other PRs, so I close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #188, #208, #209 and #210. And solves #207.
windows_newlines.datais not a valid YAML file so fix and use right implementation mentioned in #188.