Skip to content

Commit

Permalink
Merge pull request #657 from JuliaDiff/ox/fix_ci
Browse files Browse the repository at this point in the history
Restrict kwarg type in code generated by @non_differentiable macro
  • Loading branch information
oxinabox authored Jan 30, 2024
2 parents 935d625 + 99d2aed commit d2b4b94
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "ChainRulesCore"
uuid = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
version = "1.20.0"
version = "1.20.1"

[deps]
Compat = "34da2185-b29b-5c13-b0c7-acf172513d20"
Expand Down
2 changes: 1 addition & 1 deletion src/rule_definition_tools.jl
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ function _nondiff_rrule_expr(__source__, primal_sig_parts, primal_invoke)
return @strip_linenos quote
# Manually defined kw version to save compiler work. See explanation in rules.jl
function (::Core.kwftype(typeof(rrule)))(
$(esc(kwargs))::Any, ::typeof(rrule), $(esc_primal_sig_parts...)
$(esc(kwargs))::NamedTuple, ::typeof(rrule), $(esc_primal_sig_parts...)
)
return ($(esc(_with_kwargs_expr(primal_invoke, kwargs))), $pullback_expr)
end
Expand Down

2 comments on commit d2b4b94

@oxinabox
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/99818

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.20.1 -m "<description of version>" d2b4b9407eefd1ce4dc6c452fc32adca652e129d
git push origin v1.20.1

Please sign in to comment.